Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(publisher-s3): use AWS-SDK v3 #2487

Merged
merged 5 commits into from
Aug 30, 2021
Merged

Conversation

malept
Copy link
Member

@malept malept commented Aug 30, 2021

Summarize your changes:

Also fixes the credentials bug since this PR will cause a merge conflict with it.

Fixes #2226.
Closes #2258.

@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #2487 (3bfdc72) into master (5c99da4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2487   +/-   ##
=======================================
  Coverage   75.29%   75.29%           
=======================================
  Files          91       91           
  Lines        2364     2364           
  Branches      446      446           
=======================================
  Hits         1780     1780           
  Misses        473      473           
  Partials      111      111           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c99da4...3bfdc72. Read the comment docs.

@malept malept merged commit 34b3a62 into master Aug 30, 2021
@malept malept deleted the malept/refactor/aws-s3-client-s3 branch August 30, 2021 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publisher-S3: Let aws-sdk handle credential errors
1 participant