Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(publisher-github): add debug support for Octokit #2499

Merged
merged 2 commits into from
Sep 8, 2021

Conversation

malept
Copy link
Member

@malept malept commented Sep 4, 2021

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Hooks the debug module into Octokit's logging mechanism. You can enable info messages by adding electron-forge:publisher:github:info to the DEBUG environment variable, and debug messages by adding electron-forge:publisher:github:debug to the DEBUG environment variable. Please note that both will be enabled if you already have electron-forge:* in the DEBUG environment variable.

Also does some cleanup while working on the module (namely, using the userAgent option instead of setting a header).

Addresses #2498.
Fixes #1672.
Closes #1673.

@codecov
Copy link

codecov bot commented Sep 4, 2021

Codecov Report

Merging #2499 (e400c86) into master (34ba06e) will increase coverage by 1.27%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2499      +/-   ##
==========================================
+ Coverage   73.98%   75.26%   +1.27%     
==========================================
  Files          91       91              
  Lines        2364     2369       +5     
  Branches      446      448       +2     
==========================================
+ Hits         1749     1783      +34     
+ Misses        511      473      -38     
- Partials      104      113       +9     
Impacted Files Coverage Δ
packages/publisher/github/src/util/github.ts 91.30% <71.42%> (-8.70%) ⬇️
packages/maker/base/src/Maker.ts 75.67% <0.00%> (+2.70%) ⬆️
packages/api/core/src/api/lint.ts 69.23% <0.00%> (+3.84%) ⬆️
packages/maker/appx/src/MakerAppX.ts 57.14% <0.00%> (+17.85%) ⬆️
packages/maker/wix/src/MakerWix.ts 86.36% <0.00%> (+40.90%) ⬆️
packages/maker/squirrel/src/MakerSquirrel.ts 78.26% <0.00%> (+43.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34ba06e...e400c86. Read the comment docs.

@malept
Copy link
Member Author

malept commented Sep 6, 2021

There appears to be an unrelated problem with CI in general, with the native modules support. Can't really merge with that there (since it'll affect the main branch anyway).

@malept malept force-pushed the malept/feat/publisher-github/debug branch from 53b9a5f to e400c86 Compare September 8, 2021 20:43
@malept
Copy link
Member Author

malept commented Sep 8, 2021

There appears to be an unrelated problem with CI in general, with the native modules support. Can't really merge with that there (since it'll affect the main branch anyway).

I guess it was a weird transient error? Although I did repro this locally the other day, so this is very confusing.

@malept malept merged commit 73252c3 into master Sep 8, 2021
@malept malept deleted the malept/feat/publisher-github/debug branch September 8, 2021 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github Publisher Using Deprecated Options
1 participant