Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(fast): use windows-latest #2755

Merged
merged 1 commit into from
Mar 5, 2022
Merged

Conversation

malept
Copy link
Member

@malept malept commented Mar 5, 2022

Summarize your changes:

Use windows-latest (currently 2022) instead of windows-2019. Needs a very recent version of node-gyp.

@codecov
Copy link

codecov bot commented Mar 5, 2022

Codecov Report

Merging #2755 (2d0976b) into master (204ec25) will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2755      +/-   ##
==========================================
- Coverage   74.06%   73.93%   -0.13%     
==========================================
  Files          77       77              
  Lines        2356     2356              
  Branches      436      436              
==========================================
- Hits         1745     1742       -3     
- Misses        462      464       +2     
- Partials      149      150       +1     
Impacted Files Coverage Δ
packages/maker/appx/src/MakerAppX.ts 64.28% <0.00%> (-5.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 204ec25...2d0976b. Read the comment docs.

@malept malept marked this pull request as ready for review March 5, 2022 07:16
@malept malept merged commit cb5cdd5 into master Mar 5, 2022
@malept malept deleted the malept/ci/windows-2022-fast-tests branch March 5, 2022 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant