Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(resolve-dir): correctly detect working dir when use config file #3029

Closed
wants to merge 1 commit into from

Conversation

XMLHexagram
Copy link

@XMLHexagram XMLHexagram commented Oct 31, 2022

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

When use forge config file, such as forge.config.ts and forge.config.js, forge cannot correctly resolve working dir. Because forge only treat config.forge exists in package.json as a matched forge working dir. This PR fix this problem.

@XMLHexagram
Copy link
Author

Fix #3028

@MarshallOfSound
Copy link
Member

I think this was fixed in b5d0587. We technically support forge.config.* so I think the approach of "finding the first package.json with a dependency on forge" is reasonable.

@MarshallOfSound
Copy link
Member

And tested in #3031

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants