feat: allow a custom out dir from forge config

[lutzroeder]

• I have read the contribution documentation for this project.
• I agree to follow the code of conduct that this project follows, as appropriate.
• The changes are appropriately documented (if applicable).
• The changes have sufficient test coverage (if applicable).
• The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

This PR allows using a custom out directory when packaging and making an app.

#2714
#1041
#214

[BlackHole1]

Hi @lutzroeder, thank you for your PR! But CI failed. Can you fix it?

[BlackHole1]

LGTM. PTAL @dsanders11 @VerteDinde

[MarshallOfSound]

packager out dir shouldn't govern the out dir for all of forge, we should keep ignoring packager config and take in a separate out configuration, probably at the top level of the forge config.

I'm still vaguely opposed to this as a concept but won't block it on principal if others agree

[erikian]

LGTM

[ghost]

How has this project existed so long without a custom output directory?

[galens]

Its interesting how this was surfaced in 2019 (#1041) and there has yet to be any action taken on this even though a pr exists with tests and is approved. Multiple people have commented how this would be super beneficial to them, what exactly is the hold up for this?

Why is MarshallOfSound the gatekeeper of what should or shouldn't be merged into this project? I would expect because this project is open source, if someone comes with a very useful pr with tests that has been requested by dozens of people there would be some kind of action eventually taken and it merged.

[VerteDinde]

@luke-hagar-sp @galens Hey both, I appreciate that this PR may contain a change that you feel passionate about, but I'm going to ask you to please be respectful and also mindful of the fact that this is an open source project with limited maintainer resources. The opinion voiced by MarshallOfSound here is also shared by others in the maintainer group for Electron Forge. A valid technical opinion raised by a maintainer on the project is not gatekeeping.

We'll review this PR at our next working group meeting and will comment back here at that time.

[VerteDinde]

Discussed at the Ecosystem WG meeting, approved

Discussed with Sam & others in the meeting!

[MarshallOfSound]

👍

[alexandercerutti]

Hi, just to be clear: this PR added the option only when using the configuration file and not through CLI or package.json, right?

This is not documented at all on the docs site.

Thanks.

Edit: this works in package.json like this.

{
	"config": {
		"forge": {
			"outDir": "release-builds",
		}
	}
}