-
-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript :) #495
Typescript :) #495
Conversation
IMO if the tests pass on all 3 platforms (only ran locally on windows) we should just merge this, far too much to review 😄 |
At least it failed fast 😄 In a future PR, do we want to add |
Yup 👍 Along with adding typedoc to replace esdoc |
.vscode/settings.json
Outdated
"lifecycle", | ||
"rebuilder" | ||
] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably should ignore this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Summarize your changes:
See title 😉