fix(core): keep track of application restarts and close stdin pipe correctly #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
force-pushed
the
track-restarts
branch
from
ce63cff
to
9e198d0
Compare
malept
approved these changes
Sep 10, 2018
…rrectly previously we weren't tracking application restarts in the CLI module or closing our stdin pipe once the child app had quit ISSUES CLOSED: #545
MarshallOfSound
force-pushed
the
track-restarts
branch
from
9e198d0
to
a6d5b86
Compare
malept
added a commit
to electron/fiddle
that referenced
this pull request
Sep 10, 2018
Fixed via Electron Forge v6.0.0-beta.28 See: electron/forge#567
malept
added a commit
to electron/fiddle
that referenced
this pull request
Sep 10, 2018
Fixed via Electron Forge v6.0.0-beta.28 See: electron/forge#567
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we weren't tracking application restarts in the CLI module or closing our stdin pipe once
the child app had quit
ISSUES CLOSED: #545