fix: don't create console window when creating process

This commit prevents console windows from being spawned when creating processes to better align with what Windows users expect and should be removed when upgrading to a version that includes nodejs/node#21316
electron · Mar 1, 2019 · 0dae6f0 · 0dae6f0
1 parent 038d4e2
commit 0dae6f0
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/deps/uv/src/win/process.c b/deps/uv/src/win/process.c
@@ -1099,6 +1099,9 @@ int uv_spawn(uv_loop_t* loop,
     process_flags |= DETACHED_PROCESS | CREATE_NEW_PROCESS_GROUP;
   }
 
+  /* Don't create console window. */
+  process_flags |= CREATE_NO_WINDOW;
+
   if (!CreateProcessW(application_path,
                      arguments,
                      NULL,