This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix: [deps/uv] fsevents: fix file event reporting (backport: v12.x) #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 2d2af38 ("fsevents: really watch files with fsevents on macos
10.7+") from last November introduced a regression where events that
were previously reported as UV_RENAME were now reported as UV_CHANGE.
This commit rectifies that.
Fixes: nodejs/node#27869
zcbenz
approved these changes
May 28, 2019
codebytere
approved these changes
May 28, 2019
jkleinsc
changed the title
deepak1556
added a commit
to electron/electron
that referenced
this pull request
Oct 3, 2019
This reverts the patch from electron/node#100 which never got merged due to reasons outlined in libuv/libuv#2313 * Adds new patches that backports libuv/libuv#2459 and libuv/libuv#2460 Based on nodejs/node#29460
6 tasks
deepak1556
added a commit
to electron/electron
that referenced
this pull request
Oct 4, 2019
This reverts the patch from electron/node#100 which never got merged due to reasons outlined in libuv/libuv#2313 * Adds new patches that backports libuv/libuv#2459 and libuv/libuv#2460 Based on nodejs/node#29460
deepak1556
added a commit
to electron/electron
that referenced
this pull request
Oct 4, 2019
This reverts the patch from electron/node#100 which never got merged due to reasons outlined in libuv/libuv#2313 * Adds new patches that backports libuv/libuv#2459 and libuv/libuv#2460 Based on nodejs/node#29460
This was referenced Oct 4, 2019
deepak1556
added a commit
to electron/electron
that referenced
this pull request
Oct 4, 2019
This reverts the patch from electron/node#100 which never got merged due to reasons outlined in libuv/libuv#2313 * Adds new patches that backports libuv/libuv#2459 and libuv/libuv#2460 Based on nodejs/node#29460
deepak1556
added a commit
to electron/electron
that referenced
this pull request
Oct 7, 2019
This reverts the patch from electron/node#100 which never got merged due to reasons outlined in libuv/libuv#2313 * Adds new patches that backports libuv/libuv#2459 and libuv/libuv#2460 Based on nodejs/node#29460
deepak1556
added a commit
to electron/electron
that referenced
this pull request
Oct 7, 2019
This reverts the patch from electron/node#100 which never got merged due to reasons outlined in libuv/libuv#2313 * Adds new patches that backports libuv/libuv#2459 and libuv/libuv#2460 Based on nodejs/node#29460
deepak1556
added a commit
to electron/electron
that referenced
this pull request
Oct 7, 2019
This reverts the patch from electron/node#100 which never got merged due to reasons outlined in libuv/libuv#2313 * Adds new patches that backports libuv/libuv#2459 and libuv/libuv#2460 Based on nodejs/node#29460
deepak1556
added a commit
to electron/electron
that referenced
this pull request
Oct 7, 2019
This reverts the patch from electron/node#100 which never got merged due to reasons outlined in libuv/libuv#2313 * Adds new patches that backports libuv/libuv#2459 and libuv/libuv#2460 Based on nodejs/node#29460
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports libuv/libuv#2313