Implemented an 'afterExtract' function hook RE: #270 #354
Conversation
| }) | ||
| series(newFunctions, cb) | ||
| } | ||
| }) |
There was a problem hiding this comment.
I think the callback you defined for extract should be another function in the series.
There was a problem hiding this comment.
Are you suggesting then that we should do
series([extract(zipPath, {dir: buildDir})].concat(newFunctions))There was a problem hiding this comment.
I was thinking more along the lines of
function (cb) {
extract(zipPath, {dir: buildDir}, cb)
},
function (cb) {
if (opts.afterExtract exists and is not array) {
return error
}
// etc.
}...that got pseudocode-y, fast.
There was a problem hiding this comment.
Ah got it 👍
Done
|
|
||
| * `buildPath` - The path to the temporary folder where Electron has been extracted to | ||
| * `electronVersion` - The version of electron you are packaging for | ||
| * `callback` - Must be called once you have completed your actions |
There was a problem hiding this comment.
Minor nit: the rest of the file has standardized on - for list items.
MarshallOfSound
force-pushed
the
master
branch
3 times, most recently
from
8a251b2
to
f0940c8
Compare
|
Looks good, I think this just needs at least one unit test. |
|
@malept Not too familiar with the testing framework here but I added some tests 👍 |
|
The test logic looks OK at a glance (I'll look at it in more detail tomorrow), but I'd prefer if it had its own test instead of tacking it onto another test. |
|
@malept I've moved the logic to it's own test and moved it to a new file called "hooks" so that if in the future we add more of these hooks we have a place for them to go 👍 |
|
Sorry about the delay, work & real life got in the way. I had merged #351 before this one, so if you could take care of the |
|
@malept Talk about delay 😆 I finally got around to adding |
|
Amusingly enough, this morning I did something similar. The only difference is that the require statements are |
|
@malept So who's do we use 😆 |
|
I added a PR for my branch (#403). I'll wait for CI to run and then merge it. |
Add afterExtract hook Closes #354.
This PR adds an
afterExtractoption to the API. This option should be an array of functions, each of which is called directly afterelectron-packagerhas finished extracting to the temporary directory.Relevant issue: #270