Default the prune option to true #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses #35.
| @@ -194,7 +195,7 @@ module.exports = { | |||
| // * Creates temporary directory | |||
| // * Copies template into temporary directory | |||
| // * Copies user's app into temporary directory | |||
| // * Prunes non-production node_modules (if opts.prune is set) | |||
| // * Prunes non-production node_modules (if opts.prune is not false) | |||
There was a problem hiding this comment.
Pedantically speaking, either truthy or undefined.
| @@ -48,7 +48,7 @@ overwrite if output directory for a platform already exists, replaces i | |||
| skipping it | |||
| platform all, or one or more of: darwin, linux, mas, win32 (comma-delimited if multiple). | |||
| Defaults to the host platform | |||
| prune runs `npm prune --production` on the app | |||
| no-prune do not run `npm prune --production` on the app | |||
There was a problem hiding this comment.
Do you think this should this go after ignore now to keep things alphabetical?
[ci skip]
|
How come CI is not running on this PR? |
|
It did in the previous commit (note the checkmark), I skipped it in the latest one because it was just a doc change. That's some interesting UX implications in the GitHub PR UI 😃 |
|
Cool. Is this ready to ship, then? |
|
Yup! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you read the section in CONTRIBUTING.md about pull requests?
Yes
Summarize your changes:
In both the CLI and API,
prunedefaults totrue(the CLI is just more explicit about it in the code).@zeke I know you assigned yourself to #35 but I had some time the other day to work on this.
Addresses #35. (Obviously, not the
asarpart.)Fixes #235.
Are your changes appropriately documented?
The CLI docs now mentions
--no-pruneinstead of--prune. Also updated NEWS, the readme, and the API docs.Do your changes have sufficient test coverage?
Updated the defaults test, added a test for prune=false.
Does the testsuite pass successfully on your local machine?
Yes
TODO
--no-pruneshould go afterignorenow to keep things alphabetical (ref)