Add object files to default ignore patterns #491
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you read the section in CONTRIBUTING.md about pull requests?
Yes
Summarize your changes:
Avoids the step of having to ignore
.o
files when signing the app for OSX/macOS (per the Electron docs). Also ignore Windows.obj
files for completeness.@jlord @kevinsawicki @zeke do you see any potential issues with adding this regex to the default ignore list?
Are your changes appropriately documented?
Yes
Do your changes have sufficient test coverage?
Yes
Does the testsuite pass successfully on your local machine?
Yes