Add quiet option #541
Merged
Add quiet option #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When set, this prevents printing Electron Packager specific warnings and informational messages to the console. This does *not* disable errors. Fixes #538.
|
Haha, that monkeypatch makes me cry every time I look at it 😆 |
| function subOptionWarning (properties, optionName, parameter, value) { | ||
| function info (message, quiet) { | ||
| if (!quiet) { | ||
| console.error(message) |
There was a problem hiding this comment.
@malept Is there a reason you chose console.error instead of console.info/console.log?
When running in Maven and Jenkins, console.error creates a misleading error message (also displayed in red):
[ERROR] Packaging app for platform win32 x64 using electron v1.6.10
This makes it look like the packager failed to package the app
There was a problem hiding this comment.
I didn't. Explanation is here: #228 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you read the section in CONTRIBUTING.md about pull requests?
Yes
Summarize your changes:
When set, this prevents printing Electron Packager specific warnings and informational messages to the console. This does not disable errors.
CC: @MarshallOfSound mostly because we can get rid of that console monkeypatch workaround in Electron Forge.
Fixes #538.
Are your changes appropriately documented?
Yes (CLI usage, API docs).
Do your changes have sufficient test coverage?
Yes.
Does the testsuite pass successfully on your local machine?
Yes.