Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: require node-gyp@^8.4.0 & handle old Electron versions #907

Merged
merged 7 commits into from
Nov 10, 2021
Merged

fix: require node-gyp@^8.4.0 & handle old Electron versions #907

merged 7 commits into from
Nov 10, 2021

Commits on Nov 8, 2021

  1. fix: latest node-gyp with old Electron versions

    @zcbenz
    zcbenz committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    c304785 View commit details
    Browse the repository at this point in the history

  2. refactor(test): use include on expect

    @malept
    malept committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    4398825 View commit details
    Browse the repository at this point in the history

  3. refactor(test): DRY up arg creation

    @malept
    malept committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    812abaf View commit details
    Browse the repository at this point in the history

  4. refactor(test): speed up new tests by not running npm install

    @malept
    malept committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    a9d0b32 View commit details
    Browse the repository at this point in the history

  5. test(node-gyp): exhaustively test the conditional

    @malept
    malept committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    a70b2c4 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2021

  1. refactor: use semver to compare versions

    @malept
    malept committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    f2bd27f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into latest-node-gyp

    @malept
    malept authored Nov 9, 2021
    Configuration menu
    Copy the full SHA
    956b51c View commit details
    Browse the repository at this point in the history