-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible to use a local file for iconUrl instead of an actual Url? #151
Comments
I was wondering the same thing -- just came up against the same issue |
@Thomas101 electron-builder supports NSIS to produce windows installer and no such strange nupkg requirements. |
This is still an issue. You can work around this by using an file:// URL and point to the .ico file. |
This is a requirement upstream (nupkg) and |
Static hosting of Icon does not work when installing offline or in private networks. Looks like with the latest versions of NuGet this has been fixed (v5.3, August 2019), and they support locally bundled icons: Please reopen this and add support for local files! |
Won't this work?
|
No it does not. You get build errors:
Even if it could work, the file URL would have to be relative to the installation exe, since the icon file itself is not bundled, and the icon is requested during installation time. |
can we reopen this? this is still an issue on private networks with no access to the internet |
Well this worked for me to a certain extend. This made that the icon inside "Programs and Features" is the correct one. Desktop Shortcut and App Icon seem to continue not to be shown correctly, but apparently it is a caching issue with Windows since I somehow managed to fix it once by deleting this file and restarting the pc |
@Volburt7 which Windows are using to build the setup? The |
Hi,
I can get it working on my build system, but when installed by other users the add & remove program does not show the icon. I believe this is due to the icon does not pack with the installer?
I see that I can add with the nuspectemplate. Possible to add the icon as a content file and use that instead?
The text was updated successfully, but these errors were encountered: