Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: iconUrl for windows build #3194

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Conversation

@codesandbox
Copy link

codesandbox bot commented Jul 12, 2023

This branch is running in CodeSandbox. Use the links below to review this PR faster.


CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@vercel
Copy link

vercel bot commented Jul 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2023 1:44pm
affine-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2023 1:44pm
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2023 1:44pm

@pengx17 pengx17 temporarily deployed to development July 12, 2023 12:10 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development July 12, 2023 12:10 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development July 12, 2023 12:10 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development July 12, 2023 12:10 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development July 12, 2023 12:10 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development July 12, 2023 12:10 — with GitHub Actions Inactive
@github-actions github-actions bot added the app:electron Related to electron app label Jul 12, 2023
@nx-cloud
Copy link

nx-cloud bot commented Jul 12, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f88c5ac. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@pengx17 pengx17 temporarily deployed to development July 12, 2023 12:12 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development July 12, 2023 12:12 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development July 12, 2023 12:12 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development July 12, 2023 12:12 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development July 12, 2023 12:12 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development July 12, 2023 12:12 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development July 12, 2023 12:12 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development July 12, 2023 12:12 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development July 12, 2023 12:12 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development July 12, 2023 12:12 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development July 12, 2023 12:13 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5b87d90) 68.20% compared to head (f88c5ac) 68.20%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3194   +/-   ##
=======================================
  Coverage   68.20%   68.20%           
=======================================
  Files         349      349           
  Lines        8307     8307           
  Branches     1065     1065           
=======================================
  Hits         5666     5666           
  Misses       2363     2363           
  Partials      278      278           
Flag Coverage Δ
e2etest 57.20% <ø> (ø)
e2etest-macos-latest-x64 ∅ <ø> (∅)
e2etest-ubuntu-latest-x64 45.25% <ø> (ø)
e2etest-windows-latest-x64 ∅ <ø> (∅)
server-test 79.00% <ø> (ø)
unittest 55.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f88c5ac
Status: ✅  Deploy successful!
Preview URL: https://e188c2b3.affine-dev.pages.dev
Branch Preview URL: https://xp-fix-0712-windows-app-icon.affine-dev.pages.dev

View logs

@vercel vercel bot temporarily deployed to Preview – affine-storybook July 12, 2023 13:35 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview July 12, 2023 13:39 Inactive
@perfsee
Copy link

perfsee bot commented Jul 12, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …dows-app-icon                 +/- ##
===================================================================
= Bundle              5.28 MB        5.28 MB                       
= Initial JS          2.24 MB        2.24 MB                       
= Initial CSS         75.4 kB        75.4 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   71             71                       
= Chunks                   57             57                       
= Packages                207            207                       
= Duplicates               19             19                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              

@@                    EntryPoint: pages/_app                     @@
##                     master …dows-app-icon                 +/- ##
===================================================================
= Bundle              5.17 MB        5.17 MB                       
= Initial JS          2.13 MB        2.13 MB                       
= Initial CSS         75.4 kB        75.4 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   69             69                       
= Chunks                   55             55                       
= Packages                207            207                       
= Duplicates               19             19                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              

@@                   EntryPoint: pages/_error                    @@
##                     master …dows-app-icon                 +/- ##
===================================================================
= Bundle              16.6 kB        16.6 kB                       
= Initial JS          16.6 kB        16.6 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@vercel vercel bot temporarily deployed to Preview – affine-docs July 12, 2023 13:44 Inactive
@pengx17 pengx17 added this pull request to the merge queue Jul 12, 2023
Merged via the queue into master with commit e813436 Jul 12, 2023
@pengx17 pengx17 deleted the xp/fix/0712/windows-app-icon branch July 12, 2023 14:51
himself65 pushed a commit that referenced this pull request Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:electron Related to electron app
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant