Compte épargne : incrémenter après un créneau "extra" validé #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphodn
changed the base branch from
master
to
raphodn/time-log-saving-feature
raphodn
force-pushed
the
raphodn/time-log-saving-events
branch
from
5ab1529
to
c81d478
Compare
raphodn
changed the title
raphodn
changed the title
raphodn
force-pushed
the
raphodn/time-log-saving-feature
branch
from
54ff720
to
e6492c9
Compare
raphodn
force-pushed
the
raphodn/time-log-saving-events
branch
3 times, most recently
from
d4455d1
to
17e9439
Compare
petitalb
reviewed
Feb 27, 2023
| { | ||
| $log = $this->initTimeLog($member); | ||
| $log->setType(TimeLog::TYPE_REGULATE_OPTIONAL_SHIFTS); | ||
| if ($time) { |
There was a problem hiding this comment.
Comment on peut faire un log sans time ?
There was a problem hiding this comment.
bonne question, dans 99,9% des cas le paramètre $time sera non-null, mais j'ai répliqué initCustomTimeLog et initSavingTimeLog.
tu préfères qu'on force la présence du paramètre $time instead ?
There was a problem hiding this comment.
j'ai rectifié pour initSavingTimeLog et initRegulateOptionalShiftsTimeLog
pour initCustomTimeLog c'est appelé pour l'instant sans le $time donc je laisse comme ca
petitalb
approved these changes
Feb 27, 2023
raphodn
force-pushed
the
raphodn/time-log-saving-events
branch
from
17e9439
to
80e92a9
Compare
raphodn
force-pushed
the
raphodn/time-log-saving-events
branch
from
80e92a9
to
9322e4f
Compare
quot17
pushed a commit
to quot17/gestion-compte
that referenced
this pull request
Mar 28, 2023
…grenoble#768) * Rename TYPE_CYCLE_END_REGULATE_OPTIONAL_SHIFTS to TYPE_REGULATE_OPTIONAL_SHIFTS * onShiftValidated: move extra time to saving * Fix stuff
OursDesCavernes
pushed a commit
to Les400Coop/gestion-compte
that referenced
this pull request
Jan 20, 2024
…grenoble#768) * Rename TYPE_CYCLE_END_REGULATE_OPTIONAL_SHIFTS to TYPE_REGULATE_OPTIONAL_SHIFTS * onShiftValidated: move extra time to saving * Fix stuff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quoi ?
TimeLog.TYPE_CYCLE_END_REGULATE_OPTIONAL_SHIFTSenTYPE_REGULATE_OPTIONAL_SHIFTSpour le rendre plus ré-utilisable (pas seulement "cycle end")