Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chrome launcher can't kill instances failing with error #65

Closed
onderceylan opened this issue Nov 1, 2019 · 1 comment
Closed

Chrome launcher can't kill instances failing with error #65

onderceylan opened this issue Nov 1, 2019 · 1 comment
Assignees
@onderceylan
Labels
bug Something isn't working released

Comments

@onderceylan
Copy link
Collaborator

When called chrome.kill(), chrome launcher sometimes fails to kill the instance, causing lib to fail at that point.
@onderceylan onderceylan added the bug Something isn't working label Nov 1, 2019
onderceylan added a commit that referenced this issue Nov 1, 2019
@onderceylan
fix(puppets): added error handling for failing chrome kill attempt
0052ab7 
fix #65
onderceylan pushed a commit that referenced this issue Nov 1, 2019
@semantic-release-bot
chore(release): 2.1.1 [skip ci]
34071ef 
## [2.1.1](v2.1.0...v2.1.1) (2019-11-01)

### Bug Fixes

* **puppets:** added error handling for failing chrome kill attempt ([6cc65fd](6cc65fd)), closes [#65](#65)
@onderceylan
Copy link
Collaborator Author

🎉 This issue has been resolved in version 2.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@onderceylan onderceylan self-assigned this Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onderceylan onderceylan

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@onderceylan