Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add favicon only flags #70

Closed
Truth1984 opened this issue Nov 8, 2019 · 3 comments · Fixed by #78
Closed

add favicon only flags #70

Truth1984 opened this issue Nov 8, 2019 · 3 comments · Fixed by #78
Labels
feature request New feature or request released wontfix This will not be worked on

Comments

@Truth1984
Copy link

Here is the situation,
I want to generate a transparent favicon, and white background for splash and icon, but there is no such option.

when I set {favicon: true}, the program automatically generate icon & splash for me

Thus here is my workaround, first I generate favicon with { opaque: false, iconOnly: true, favicon: true } and then overwrite it with {background:"#FFFFFF", favicon:false} option.

I wonder if we can add faviconOnly flag.

@Truth1984 Truth1984 added the feature request New feature or request label Nov 8, 2019
@onderceylan
Copy link
Collaborator

Hi @Truth1984, thanks for the feedback! Looks like you found a nice workaround for this edge case.

Currently, generating favicon is coupled with app icon generation, which kinda made sense back then. But now I consider changing --favicon flag to --favicon-only by also decoupling it from the rest of icon generation.

@onderceylan
Copy link
Collaborator

After a second thought, I think it's better to park this issue for now by updating the FAQ section of the readme. Adding an additional faviconOnly flag will not help with reducing the CLI calls in this scenario and it will add more complexity to the lib by putting a focus on favicon, which shouldn't be the goal of the lib IMHO. We might resurrect it if it gets more attention from the users in the future ✌️Thanks for the help @Truth1984!

@onderceylan onderceylan added the wontfix This will not be worked on label Dec 17, 2019
onderceylan added a commit that referenced this issue Dec 17, 2019
Added guidelines for generating a transparent favicon

fix #70
onderceylan added a commit that referenced this issue Dec 19, 2019
Added guidelines for generating a transparent favicon

fix #70
@onderceylan
Copy link
Collaborator

🎉 This issue has been resolved in version 2.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request released wontfix This will not be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants