Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to see which General is which in Filter/Search #3943

Closed
daniellekirkwood opened this issue Sep 1, 2021 · 14 comments · Fixed by #5860
Closed

Not able to see which General is which in Filter/Search #3943

daniellekirkwood opened this issue Sep 1, 2021 · 14 comments · Fixed by #5860
Assignees
Labels
A-Search A-Spaces Spaces, groups, communities O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-IA Issue is related to information architecture Z-Labs

Comments

@daniellekirkwood
Copy link
Contributor

Steps to reproduce

  1. Click Filter (from Rooms in private space)
  2. Search for "General"

general search

What did you expect?

To be able to know which Space each General room is in

What happened?

Long list of "General" and I didn't know which one I wanted to click on

Your phone model

No response

Operating system version

No response

Application version and app store

https://buildkite.com/organizations/matrix-dot-org/pipelines/element-android/builds/3224/jobs/a1fe572d-8a7b-4406-8a0f-37f4c9ff4787/artifacts/30990f61-8f7d-4dc6-af1e-340765110cc6

Homeserver

No response

Have you submitted a rageshake?

No

@daniellekirkwood daniellekirkwood added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems A-Spaces Spaces, groups, communities S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely X-Needs-Design May require input from the design team labels Sep 1, 2021
@daniellekirkwood
Copy link
Contributor Author

Relabelling as Enhancement and tagging with IA.

This is not Android specific either

@daniellekirkwood daniellekirkwood added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-IA Issue is related to information architecture labels Sep 21, 2021
@BillCarsonFr BillCarsonFr self-assigned this Sep 29, 2021
@niquewoodhouse
Copy link

Two suggestions from design:

  • Add in Space name underneath the room name. If in multiple spaces, say in Space name and 3 others.
  • Separate the list into sections like other lists in the app (with each space being a section with a sticky header)

@niquewoodhouse
Copy link

niquewoodhouse commented Oct 7, 2021

Just adding mockups to this (mockups of different app area, but similar content)

This is not Android specific either

@daniellekirkwood might be worth making issues for web and iOS also then. I think this is one that already exists for web.

@daniellekirkwood
Copy link
Contributor Author

@niquewoodhouse The ticket you linked is about something else, however I have created a web issue for this same thing... element-hq/element-web#19349

@kittykat kittykat added X-Needs-Design May require input from the design team and removed X-Needs-Design May require input from the design team labels Jan 7, 2022
@kittykat kittykat changed the title Not able to see which General is which in Filter Not able to see which General is which in Filter/Search Jan 21, 2022
@fedrunov
Copy link
Contributor

fedrunov commented Feb 2, 2022

@niquewoodhouse we already show last event in the room as a "subtitle", so it's conflicting with space name.

Screenshot 2022-02-02 at 13 00 57

Should we replace this last event text with a space name in Search screen specifically? If so, is there any other places, where we would like to have same changes?

@niquewoodhouse
Copy link

@niquewoodhouse we already show last event in the room as a "subtitle", so it's conflicting with space name.

If that's the case, are we able to know why the issue reporter had no last event showing?

Should we replace this last event text with a space name in Search screen specifically?

I have no insights as to whether the last event is useful when filtering, so I think we should go ahead and replace and await feedback.

If so, is there any other places, where we would like to have same changes?

These are the other places where it might be useful that I know of.

  • When a user is making a personal space (create space > private > just me), they get a list of rooms/DMs they can add to the space.
  • When a user is adding existing rooms to a space (add room to space)

@fedrunov
Copy link
Contributor

fedrunov commented Feb 3, 2022

If that's the case, are we able to know why the #3943 (comment) had no last event showing?

General is a generic room name we propose to user when they create a space. I assume there were many spaces created for testing purpose or so and every space have "General" and "Random" rooms. On my screen I also had them without any events until I wrote 1 message to each, just to illustrate

@kittykat
Copy link
Contributor

kittykat commented Feb 3, 2022

@niquewoodhouse we already show last event in the room as a "subtitle", so it's conflicting with space name.

If that's the case, are we able to know why the issue reporter had no last event showing?

These were new rooms with no activity that we were using for testing

For this issue, when we are filtering joined rooms, we are interested in the room context so we want to know which space it is in. Lets split the context out for different views and this view should show Space instead of last event.

@ericdecanini ericdecanini self-assigned this Apr 15, 2022
@ericdecanini
Copy link
Contributor

@niquewoodhouse @daniellekirkwood how should we handle this for rooms that don't belong to a space or for DMs?

I can see that the windows client does this

image

  • For rooms that belong to a space, we show the space
  • For dm rooms, we show the username
  • For rooms that do not belong to a space, we show the.... id of the room? Idk exactly what it's called but its shown above

Do we want to achieve the same on android?

@ericdecanini
Copy link
Contributor

image

There is also this case where you have dm rooms with multiple people. Web shows the user id of the first user in the group. Is this expected behaviour and do we want to be doing the same

@ericdecanini
Copy link
Contributor

One more question:

image

Do we still want to show all the metadata we currently show? i.e. unread massages badge, last message time, typing indicator, and possibly also the presence indicator?

@ericdecanini
Copy link
Contributor

image

There are also cases such as these rooms. We don't have an alias to show (e.g. #delight:element.io). Web shows nothing, data-wise, we have the room topic and room id at our disposal (though i doubt we'd want to show the room id). What do we wanna do in these cases?

@niquewoodhouse
Copy link

For rooms that belong to a space, we show the space
For dm rooms, we show the username
For rooms that do not belong to a space, we show the.... id of the room? Idk exactly what it's called but its shown above
Do we want to achieve the same on android?

Yes.

...this case where you have dm rooms with multiple people. Web shows the user id of the first user in the group. Is this expected behaviour and do we want to be doing the same

Erm, this wasn't expected behaviour for me but it might be because I'm not in those kind of chats so not sure how it should work. In any case its probably best to copy that behaviour for consistency and if it turns out to be the wrong call, we can raise a meta ticket to fix them both rather than do something else here.

...these rooms. We don't have an alias to show (e.g. #delight:element.io). Web shows nothing, data-wise, we have the room topic and room id at our disposal (though i doubt we'd want to show the room id). What do we wanna do in these cases?

Don't show anything.

@niquewoodhouse
Copy link

Do we still want to show all the metadata we currently show? i.e. unread massages badge, last message time, typing indicator, and possibly also the presence indicator?

Items with tick we should show

  • Unread messages badge
  • Last message time
  • Typing indicator
  • Presence indicator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Search A-Spaces Spaces, groups, communities O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-IA Issue is related to information architecture Z-Labs
Projects
None yet
6 participants