Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement MSC3987: Push actions clean-up #8503

Closed
giomfo opened this issue Jun 5, 2023 · 0 comments
Closed

Implement MSC3987: Push actions clean-up #8503

giomfo opened this issue Jun 5, 2023 · 0 comments
Labels
A-Notifications T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@giomfo
Copy link
Member

giomfo commented Jun 5, 2023 •
edited
Loading

Steps to reproduce

Following MSC3987: Push actions clean-up, some recent clients mute a room by adding a new push rule with an empty list of actions

Outcome

This push is ignored in Element-Android, the room is not displayed as muted room.

Element-Android SDK must support empty list of actions in push rules. This empty list must be considered as a "Don't notify" action

Your phone model

No response

Operating system version

No response

Application version and app store

No response

Homeserver

No response

Will you send logs?

No

Are you willing to provide a PR?

Yes
@giomfo giomfo added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Jun 5, 2023
@kittykat kittykat added A-Notifications T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements and removed T-Defect Something isn't working: bugs, crashes, hangs and other reported problems labels Jun 9, 2023
@yostyle yostyle mentioned this issue Jun 13, 2023
Merged
15 tasks
@giomfo giomfo closed this as completed Jun 27, 2023
@giomfo giomfo mentioned this issue Jun 27, 2023
Closed
@yostyle yostyle mentioned this issue Sep 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Notifications T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kittykat @giomfo