Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to record and send videos. #2411

Closed
wants to merge 5 commits into from
Closed

Added option to record and send videos. #2411

wants to merge 5 commits into from

Conversation

c-andy-candies
Copy link

@c-andy-candies c-andy-candies commented Nov 17, 2020

Signed-off-by: Andrea Conalbi [email protected]

Pull Request Checklist

  • Changes has been tested on an Android device or Android emulator with API 21
  • UI change has been tested on both light and dark themes
  • Pull request is based on the develop branch
  • Pull request updates CHANGES.md
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off

I basically adapted the code of the "camera attachment" for video recording adding a button in the attachments list.
Sorry if I made mistakes, it's my first PR ever.

@c-andy-candies c-andy-candies changed the title added option to record and send videos. Added option to record and send videos. Nov 18, 2020
@bmarty
Copy link
Member

bmarty commented Nov 19, 2020

Hello @c-andy-proj,

Thanks for the PR, it is working well, and I have no remark on the code. The layout could maybe be improved, this is quite strange to have empty LinearLayout, to center the new "video" icon.

The rendering could maybe be improved, this is what I see on my device:

image

Previously this area was supposed to have the same size than the virtual keyboard, and if the keyboard is open, it is displayed above the keyboard. But now this is like that:

image

This is not ideal.

The icon should be white like the other.

WhatsApp is using a scroll, which is not better I think:

image

I will ask to the design team if they have another idea.

@bmarty bmarty added the X-Needs-Design May require input from the design team label Nov 19, 2020
@kojid0
Copy link
Contributor

kojid0 commented Jan 21, 2021

The issue would be solved when we move "Sticker" to the emoji picker.
Stickers are a bit related to emoji, so I would prefer having them integrated in the emoji picker anyway, just like other messengers do:
82835951-c2131d80-9ec5-11ea-8317-69204392b538 (Handy)

bmarty added a commit that referenced this pull request May 3, 2021
bmarty added a commit that referenced this pull request May 3, 2021
@bmarty
Copy link
Member

bmarty commented May 5, 2021

Replaced by #3264

@bmarty bmarty closed this May 5, 2021
@c-andy-candies c-andy-candies deleted the record-videos branch May 6, 2021 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
X-Needs-Design May require input from the design team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants