FTUE - Account created screen #5158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ouchadam
added
the
Z-FTUE
Matrix SDKIntegration Tests Results:
|
…tate - allows for greater control of the flow (such as adding new screens inbetween the creation and exit with flags)
…ps are still TODO
… into the main app
…avoid going back to the sign up screens
ouchadam
force-pushed
the
feature/adm/ftue-post-account-creation
branch
from
8b9d484
to
c308142
Compare
ouchadam
force-pushed
the
feature/adm/ftue-post-account-creation
branch
from
c308142
to
e0f99e3
Compare
This was referenced Feb 10, 2022
ganfra
approved these changes
Feb 15, 2022
| @@ -147,6 +147,8 @@ class OnboardingViewModel @AssistedInject constructor( | |||
| is OnboardingAction.UserAcceptCertificate -> handleUserAcceptCertificate(action) | |||
| OnboardingAction.ClearHomeServerHistory -> handleClearHomeServerHistory() | |||
| is OnboardingAction.PostViewEvent -> _viewEvents.post(action.viewEvent) | |||
| OnboardingAction.PersonalizeProfile -> _viewEvents.post(OnboardingViewEvents.OnPersonalizeProfile) | |||
There was a problem hiding this comment.
Do we really need that? It's ok but feels a bit useless when there is really no other code involved
There was a problem hiding this comment.
yeah I wasn't sure about this as well, sounds like I should use OnboardingAction.PostViewEvent which acts as a proxy to post events directly to the ViewModel.viewEvents observer
…ed actions/events
bmarty
approved these changes
Feb 17, 2022
|
|
||
| private fun setupViews() { | ||
| views.accountCreatedSubtitle.text = getString(R.string.ftue_account_created_subtitle, activeSessionHolder.getActiveSession().myUserId) | ||
| views.accountCreatedPersonalize.setOnClickListener { viewModel.handle(OnboardingAction.PostViewEvent(OnboardingViewEvents.OnPersonalizeProfile)) } |
There was a problem hiding this comment.
Nit: use debouncedClicks instead of setOnClickListener
| private fun setupViews() { | ||
| views.accountCreatedSubtitle.text = getString(R.string.ftue_account_created_subtitle, activeSessionHolder.getActiveSession().myUserId) | ||
| views.accountCreatedPersonalize.setOnClickListener { viewModel.handle(OnboardingAction.PostViewEvent(OnboardingViewEvents.OnPersonalizeProfile)) } | ||
| views.accountCreatedTakeMeHome.setOnClickListener { viewModel.handle(OnboardingAction.PostViewEvent(OnboardingViewEvents.OnTakeMeHome)) } |
|
|
||
| override fun onBackPressed(toolbarButton: Boolean): Boolean { | ||
| viewModel.handle(OnboardingAction.PostViewEvent(OnboardingViewEvents.OnTakeMeHome)) | ||
| return false |
There was a problem hiding this comment.
I think you should return true here, but the contract is not clear (too me). So I am not sure. But it looks like you consume the back event so you should stop the propagation (if I am right).
There was a problem hiding this comment.
ah great catch! 4975406
| @@ -16,4 +16,10 @@ | |||
|
|
|||
| <!-- onboarding english only word play --> | |||
| <string name="cut_the_slack_from_teams" translatable="false">Cut the slack from teams.</string> | |||
|
|
|||
| <!-- WIP --> | |||
| <string name="ftue_account_created_personalize" translatable="false">Personalise profile</string> | |||
There was a problem hiding this comment.
Default is EN-US so it has to be
Suggested change
| <string name="ftue_account_created_personalize" translatable="false">Personalise profile</string> | |
| <string name="ftue_account_created_personalize" translatable="false">Personalize profile</string> |
There was a problem hiding this comment.
👍 will also let design/product know 06f2ca1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4586 element-hq/element-meta#132
personalise profilebutton TODO is handled by FTUE - Choose a display name #5211