Feature/5575 custom auth params for sign up

[TarasSmakula]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

• Added currentRegistrationSessionId into RegistrationWizard to add possibility to perform custom sign up stage
• Added registrationOther into RegistrationWizard to send custom auth params for sign up
• Moved terms converter into api package to make it accessible in sdk

Motivation and context

#5575

Screenshots / GIFs

Tests

I am using matrix-android-sdk2 in my current project as a local module. Tested different sign up stages on real device and emulator

Tested devices

• Physical
• Emulator
• OS version(s):
  Pixel 3 Android 12

Checklist

• Changes has been tested on an Android device or Android emulator with API 21
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR
• If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

[bmarty]

Thanks for your PR!

Added currentRegistrationSessionId into RegistrationWizard to add possibility to perform custom sign up stage

See my comment, I think this is not necesary to expose the sessionId to the app.

Added registrationOther into RegistrationWizard to send custom auth params for sign up

OK

Moved terms converter into api package to make it accessible in sdk

As far as I understand, converter is not used by the SDK even after the change in this PR. So why do you want to move this code to the SDK?

Last points:

• can you sign-off your PR else, I will not be able to merge it. Thank!
• can you add a file for the changelog with extension .sdk ? See the contributing doc to get more info about that.

[TarasSmakula]

As far as I understand, converter is not used by the SDK even after the change in this PR. So why do you want to move this code to the SDK?

Yep, just made this mapping accessible for others sdk users. Using this in my current project to build terms list.
So i think it will be good to have this publicly available in sdk.

[bmarty]

Thanks for the update!

[bmarty]

Thanks for your update. There is still some renaming to do. Also there is a conflict to fix, can you handle it please?

Once done, I think we will be able to merge your PR. Thanks!

[bmarty]

Thanks for the update!