VoIP Screen Sharing Permission #5811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onurays
changed the title
onurays
requested review from
a team and
mnaturel
and removed request for
a team
onurays
requested review from
a team and
ericdecanini
and removed request for
mnaturel and
a team
ericdecanini
approved these changes
Apr 21, 2022
| @@ -30,6 +30,8 @@ sealed class VectorCallViewEvents : VectorViewEvents { | |||
| object ShowDialPad : VectorCallViewEvents() | |||
| object ShowCallTransferScreen : VectorCallViewEvents() | |||
| object FailToTransfer : VectorCallViewEvents() | |||
| object ShowScreenSharingPermissionDialog : VectorCallViewEvents() | |||
| object StopScreenSharingService : VectorCallViewEvents() | |||
There was a problem hiding this comment.
Optional: This is a good opportunity to get rid of the commented code below. They're nearly 2 years old, I don't think we'll need it
Comment on lines
34
to
37
| // Show a sticky notification | ||
| val notificationId = System.currentTimeMillis().toInt() | ||
| val notification = notificationUtils.buildScreenSharingNotification() | ||
| startForeground(notificationId, notification) |
There was a problem hiding this comment.
Optional: extracting this code into a private fun showStickyNotification() could get rid of the need for a comment ;)
added 2 commits
April 21, 2022 15:09
* develop: (107 commits) Fixes long line and comment lint errors Fixes lint errors Adds changelog file Formats entire project Adds changelog file Makes MediaType internal Bump libphonenumber from 8.12.46 to 8.12.47 updating release version in preparation for next cycle generating changelog Replaces writeAsync with awaitTransaction Replaces doWithRealm with writeAsync Translated using Weblate (Polish) Translated using Weblate (Slovak) Crash: open private room by link. Use RoomId instead of the alias. Translated using Weblate (Arabic) Makes MediaFileUtils function internal Removes runCatching from TemporaryFileCreator using unix end of line character instead of windows as *nix OSes are more common dev environments remove spaces feedback from left panel (#5686) Translated using Weblate (French) ... # Conflicts: # vector/src/main/java/im/vector/app/features/call/VectorCallViewModel.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial PR for screen sharing during a call.