Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diag request for Synapse #5948

Merged
merged 1 commit into from
May 9, 2022
Merged

Add diag request for Synapse #5948

merged 1 commit into from
May 9, 2022

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented May 5, 2022

Improve the hs_diag script to fetch info about the server version:

For instance, when running ./tools/hs_diag.py -s matrix.org

We will get this extra bloc:

====================================================================================================
# Synapse version (https://matrix.org/_synapse/admin/v1/server_version)
====================================================================================================
{
    "server_version": "1.58.0rc2",
    "python_version": "3.7.3"
}

@bmarty bmarty requested review from a team, onurays and fedrunov and removed request for a team May 5, 2022 13:36
@bmarty bmarty added the PR-Small PR with less than 20 updated lines label May 5, 2022
@github-actions
Copy link

github-actions bot commented May 5, 2022

Unit Test Results

122 files  ±0  122 suites  ±0   2m 22s ⏱️ +15s
205 tests ±0  205 ✔️ ±0  0 💤 ±0  0 ±0 
690 runs  ±0  690 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 8e31906. ± Comparison against base commit c9bd1f3.

Copy link
Contributor

@onurays onurays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM! (I just re-run the lint runner)

Copy link
Contributor

@ouchadam ouchadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL about this helper 👍

thinking out loud for more features, could also be helpful to grab the homeservers .wellknown and (just seen we're already doing this!) ssl/tls certificates

@bmarty
Copy link
Member Author

bmarty commented May 9, 2022

Thanks for the review. Any improvement on this helper would be considered :)

@bmarty bmarty merged commit 92cb21a into develop May 9, 2022
@bmarty bmarty deleted the feature/bma/user_name branch May 9, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Small PR with less than 20 updated lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants