Correct public_baseurl for nightly tests. #5949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So the change in fb19d6b seems to have been powerful in itself; the baseurl was wrong for a number of the tests (compared to running locally). |
bmarty
reviewed
May 5, 2022
michaelkaye
changed the title
|
We may as well merge this as-is. |
ouchadam
approved these changes
May 9, 2022
|
I have this change locally as it's needed for the sanity tests to login in after creating an account |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests seem to function against a synapse with an incorrect public_baseurl - some parts of the client use the public_baseurl for information and timeout, others use the configured http endpoint (which is hardcoded in the tests to be correct).
Making this change reduces timeouts waiting for requests to these incorrect endpoints.