Fixes inconsistent rooms in home behaviour #6511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…consistent value - only uses the previous value if the key exists, otherwise we end up defaulting to true instead of false (which the preferences screen expects) - manually deletes the key after migrating the value
ouchadam
requested review from
a team and
onurays
and removed request for
a team
onurays
reviewed
Jul 11, 2022
| } | ||
|
|
||
| private fun labsSpacesOnlyOrphansInHome(): Boolean { | ||
| return defaultPrefs.getBoolean(SETTINGS_LABS_SPACES_HOME_AS_ORPHAN, false) |
There was a problem hiding this comment.
Do we have to live with this or can we remove this flag in the next releases?
There was a problem hiding this comment.
I totally agree. They (if there are any users) shouldn't be so surprised.
There was a problem hiding this comment.
removed ♻️ 6266b20
onurays
approved these changes
Jul 11, 2022
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
SETTINGS_LABS_SPACES_HOME_AS_ORPHANmigration for the showing rooms in home, it's the cause of a inconsistent stateMotivation and context
Fixes #6510 Inconsistent rooms in home behaviour
The app incorrectly returns the
Show all rooms in homepreference as enabled when it's meant to be disabled by default. This is caused by the migration logic from the previous flag not taking into account if the preference existed, causing us to always default to enabled.Will also fix some flakiness in the UI Tests!
Screenshots / GIFs
Tests
Tested devices