-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
View event replay #7917
Merged
Merged
View event replay #7917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
added
the
Z-NextRelease
For issues and PRs which should be included in the NextRelease.
label
Jan 9, 2023
bmarty
requested review from
a team and
jmartinesp
and removed request for
a team
January 9, 2023 17:01
bmarty
force-pushed
the
feature/bma/viewEventReplay
branch
from
January 10, 2023 09:40
8bbd88f
to
9b421e2
Compare
jmartinesp
approved these changes
Jan 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a minor comment about documenting the workaround.
bmarty
force-pushed
the
feature/bma/viewEventReplay
branch
from
January 10, 2023 09:52
9b421e2
to
02c61d3
Compare
Kudos, SonarCloud Quality Gate passed! |
ganfra
approved these changes
Jan 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better like this, thanks!
This was referenced Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
#7724 introduced a regression, especially on the login screen.
In case of error, a ViewEvent can be triggered. But next Fragment to be displayed will also handle this Event, which is not expected.
The change in this PR ensure that Event older than 150ms cannot be handled.
Navigation Event triggered when the app is in background can be ignored due to this change, but this is an edge case, and we do not want to do a bigger rework of this part on the code base right now, and fixing the issue is more important.
Motivation and context
Mainly avoid displaying several time the same issue during the sign up / sign in flow.
Screenshots / GIFs
Tests
Tested devices
Checklist