Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The app never waits for to-device events to be decrypted #428

Closed
robintown opened this issue Jun 30, 2022 · 2 comments
Closed

The app never waits for to-device events to be decrypted #428

robintown opened this issue Jun 30, 2022 · 2 comments
Labels
O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs, vulnerabilities, or other reported problems Z-Splitbrain Someone who should be on the call isn't showing up

Comments

@robintown
Copy link
Member

robintown commented Jun 30, 2022 •
edited
Loading

https://github.com/matrix-org/matrix-js-sdk/blob/robertlong/group-call/src/webrtc/callEventHandler.ts#L143

The above doesn't seem to be accomplishing anything, and is a possible source of signaling failures / splitbrains.
@robintown robintown added T-Defect Something isn't working: bugs, crashes, hangs, vulnerabilities, or other reported problems S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Uncommon Most users are unlikely to come across this or unexpected workflow Z-Splitbrain Someone who should be on the call isn't showing up labels Jun 30, 2022
@dbkr
Copy link
Member

dbkr commented Jun 30, 2022

I did wonder about this code as it didn't appear to be doing anything, although we do wait for everything to be decrypted in https://github.com/matrix-org/matrix-js-sdk/blob/robertlong/group-call/src/webrtc/callEventHandler.ts#L90

dbkr added a commit to matrix-org/matrix-js-sdk that referenced this issue Jul 1, 2022
@dbkr
Remove empty decryption listener
3685c72 
This listener looks like it was left over from something as it just
did nothing at all. The todevice event gets put into the call
event buffer which awaits on decryption for each event before
processing, so it should already wait for decryption.

More info: element-hq/element-call#428
@dbkr dbkr mentioned this issue Jul 1, 2022
Merged
dbkr added a commit to matrix-org/matrix-js-sdk that referenced this issue Jul 1, 2022
@dbkr
Remove empty decryption listener (#2486)
6ea2885 
* Remove empty decryption listener

This listener looks like it was left over from something as it just
did nothing at all. The todevice event gets put into the call
event buffer which awaits on decryption for each event before
processing, so it should already wait for decryption.

More info: element-hq/element-call#428

* Unused import

* Unused function!
@robintown
Copy link
Member Author

seems clear that I was wrong

@robintown robintown closed this as not planned Won't fix, can't repro, duplicate, stale Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs, vulnerabilities, or other reported problems Z-Splitbrain Someone who should be on the call isn't showing up
Projects
No open projects
Element Call issue triage
Status: Closed
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dbkr @robintown