Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group Call Tests: Incoming calls #532

Closed
Tracked by #2552
, #409
...
dbkr opened this issue Aug 17, 2022 · 0 comments
Closed
Tracked by #2552
, #409
...

Group Call Tests: Incoming calls #532

dbkr opened this issue Aug 17, 2022 · 0 comments
Assignees
@dbkr
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks

Comments

@dbkr
Copy link
Member

dbkr commented Aug 17, 2022

Your use case

Test the various code paths in GroupCall.onIncomingCall

Have you considered any alternatives?

No response

Additional context

No response
@dbkr dbkr added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Aug 17, 2022
@dbkr dbkr self-assigned this Aug 17, 2022
dbkr added a commit to matrix-org/matrix-js-sdk that referenced this issue Aug 17, 2022
@dbkr
Add tests for incoming calls in group calls
9f6e8a3 
Inspiration wwlecome for the renamed describe group which we're
really abusing for a bunch of things that happen to have the same
dependencies.

Fixes element-hq/element-call#532
@dbkr dbkr mentioned this issue Aug 17, 2022
Merged
3 tasks
dbkr added a commit to matrix-org/matrix-js-sdk that referenced this issue Aug 17, 2022
@dbkr
Add tests for incoming calls in group calls (#2597)
2566c40 
* Add tests for incoming calls in group calls

Inspiration wwlecome for the renamed describe group which we're
really abusing for a bunch of things that happen to have the same
dependencies.

Fixes element-hq/element-call#532

* Extract incoming call tests out into their own describe

and get the lexicographical ordering to match who should be calling who

* Trailing space
@dbkr dbkr closed this as completed Aug 17, 2022
@fkwp fkwp mentioned this issue Oct 13, 2022
Closed
16 tasks
@fkwp fkwp mentioned this issue Nov 30, 2022
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbkr dbkr

Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dbkr