Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group Calls Tests: Screenshare on 1:1 calls #548

Closed
Tracked by #2552
, #409
...
dbkr opened this issue Aug 23, 2022 · 0 comments
Closed
Tracked by #2552
, #409
...

Group Calls Tests: Screenshare on 1:1 calls #548

dbkr opened this issue Aug 23, 2022 · 0 comments
Assignees
@dbkr
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks

Comments

@dbkr
Copy link
Member

dbkr commented Aug 23, 2022

Your use case

Add tests for the various cases of screen sharing (with & without metadata) on 1:1 calls

Have you considered any alternatives?

No response

Additional context

No response
@dbkr dbkr added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Aug 23, 2022
@dbkr dbkr self-assigned this Aug 23, 2022
dbkr added a commit to matrix-org/matrix-js-sdk that referenced this issue Aug 23, 2022
@dbkr
1:1 screenshare tests
4a294c9 
Fixes element-hq/element-call#548
dbkr added a commit to matrix-org/matrix-js-sdk that referenced this issue Aug 23, 2022
@dbkr
1:1 screenshare tests
d46ba27 
Fixes element-hq/element-call#548
@dbkr dbkr mentioned this issue Aug 23, 2022
Merged
3 tasks
dbkr added a commit to matrix-org/matrix-js-sdk that referenced this issue Aug 24, 2022
@dbkr @robintown
1:1 screenshare tests (#2617)
9e1b126 
* 1:1 screenshare tests

Fixes element-hq/element-call#548

* Always hang up calls after tests

to prevent hanging tests

Also fix a null dereference as we may not have an invitee or opponent
member when sending voip events if not using to-device messages.

* use mockImplementationOnce

Co-authored-by: Robin <[email protected]>

* use mockImplementationOnce

Co-authored-by: Robin <[email protected]>

* Add type on mock

* Add corresponding call.off

* Merge enable & disable screenshare tests

Co-authored-by: Robin <[email protected]>
@dbkr dbkr closed this as completed Aug 24, 2022
@dbkr dbkr mentioned this issue Aug 25, 2022
Closed
@fkwp fkwp mentioned this issue Oct 13, 2022
Closed
16 tasks
@fkwp fkwp mentioned this issue Nov 30, 2022
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbkr dbkr

Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dbkr