Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add waiting state for media tile #669

Closed
SimonBrandner opened this issue Oct 26, 2022 · 1 comment · Fixed by #752
Closed

Add waiting state for media tile #669

SimonBrandner opened this issue Oct 26, 2022 · 1 comment · Fixed by #752
Assignees
@dbkr
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@SimonBrandner
Copy link
Contributor

SimonBrandner commented Oct 26, 2022 •
edited
Loading

Show a Waiting for media text on a tile while we're connecting instead of a gray rectangle
@SimonBrandner SimonBrandner added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements O-Occasional Affects or can be seen by some users regularly or most users rarely labels Oct 26, 2022
@robintown robintown added the X-Needs-Design May require input from the design team label Oct 31, 2022
@robintown
Copy link
Member

(Or a generic loading indicator of some sort, since 'media' in this context might come across as jargon)

@dbkr dbkr self-assigned this Nov 15, 2022
dbkr added a commit that referenced this issue Nov 15, 2022
@dbkr
Add a 'waiting for video' state to media tiles
80f07a5 
This will show if the call is waiting for media to connect (in practice
doesn't actually seem to happen all that often) but also show if the
media connection is lost, with the js-sdk change.

Requires matrix-org/matrix-js-sdk#2880
Fixes: #669
@dbkr dbkr mentioned this issue Nov 15, 2022
Merged
@dbkr dbkr closed this as completed in #752 Nov 16, 2022
@gaelledel gaelledel removed the X-Needs-Design May require input from the design team label Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbkr dbkr

Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
No open projects
Element Call issue triage
Status: Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a 'waiting for video' state to media tiles element-hq/element-call
4 participants
@dbkr @SimonBrandner @robintown @gaelledel