Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the device that's actually in use #1670

Draft
wants to merge 4 commits into
base: livekit
Choose a base branch
from

Commits on Oct 2, 2023

  1. Show the device that's actually in use

    Feeds the current track (if any), and therefore device it's using
    into the device selection dropdown and implement a some somewhat
    complex logic to observe when the 'default' device has changed to
    a different actual devbice between when we opened it and now, and
    display the device we're actually using as selected instead.
    
    The comments should explain more, including the caveat that we can't
    do the same detective work if the device is one of several devices
    on the same bit of hardware. This is because is uses the same groupId
    comparison technique used by Livekit in `normalizeDeviceId` to do
    a smiliar thing.
    dbkr committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    aff01d0 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. Expand comment

    Co-authored-by: Timo <[email protected]>
    dbkr and toger5 authored Oct 5, 2023
    Configuration menu
    Copy the full SHA
    8884982 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. Fix logic a bit as per comments

    (and... add comments)
    dbkr committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    6d2d564 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'dbkr/show_device_actually_in_use' of github.com:vector-…

    …im/element-call into dbkr/show_device_actually_in_use
    dbkr committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    2f05125 View commit details
    Browse the repository at this point in the history