Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add f-twelve web console #1842

Draft
wants to merge 4 commits into
base: livekit
Choose a base branch
from
Draft

Add f-twelve web console #1842

wants to merge 4 commits into from

Conversation

toger5
Copy link
Contributor

@toger5 toger5 commented Oct 30, 2023

This is a very quick way to get access to the log on ios and andoird without needing to rageshake and check it on the rageshake.

Could come in handy as well to be able to execute arbitrary commands in the webconsole on andoid/ios.

Screenshots

Screenshot 2023-10-30 at 15 05 14 Screenshot 2023-10-30 at 15 05 19 Screenshot 2023-10-30 at 15 05 24

Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's useful then I guess this is okay. Main concerns are:

  • How much does it add to the bundle size?
  • Does it add another thing intercepting our logs and if so does it play okay with everything else?
  • Hasn't been updated for 2 years and does pull in preact which gives it a bunch of dependencies, none of which have had updates in those 2 years.

@toger5
Copy link
Contributor Author

toger5 commented Oct 30, 2023

I spend some time searching for a more recent one but this seemed the only bigger project.
I basically had the same concerns. (preact, super old)
It also does not contain everythign we can find in the actual log of the browser console. It is still super helpful now.
Maybe just leafving it as a PR and rebasing it from time to time on the default branch is the best solution for now.

Then I can use this branch for debugging but its not really part of EC. (Until we find something newer with less deps.)

@toger5 toger5 marked this pull request as draft October 30, 2023 16:30
@CLAassistant
Copy link

CLAassistant commented Sep 6, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants