Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump js-sdk dependency to encrypt to-device messages #337

Merged
merged 2 commits into from
May 19, 2022

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented May 18, 2022

Fixes #257

@dbkr dbkr requested a review from robertlong May 18, 2022 13:54
@dbkr
Copy link
Member Author

dbkr commented May 18, 2022

Probably want to wait for matrix-org/matrix-js-sdk#2383 and then bump this to include that

@robertlong
Copy link
Contributor

Now I'm confused. Which version of js-sdk is in this PR #333

We definitely should wait to roll out E2E if it breaks when the other members don't have E2E keys.

@dbkr dbkr mentioned this pull request May 19, 2022
@dbkr
Copy link
Member Author

dbkr commented May 19, 2022

#333 was to pull in the fix for races when muting / unmuting - I've closed it in favour of this one (which is a bit of an arbitrary choice since this one will want to be changed to a new sha once that js-sdk PR is merged).

@dbkr dbkr requested a review from a team as a code owner May 19, 2022 18:10
Copy link
Contributor

@robertlong robertlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Let's test more on staging.

@dbkr dbkr merged commit c714a06 into main May 19, 2022
@dbkr dbkr deleted the dbkr/bump_js_sdk_for_olm branch December 21, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable E2EE by default
2 participants