-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add internationalisation support #188
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germain-gg
commented
Apr 26, 2021
t3chguy
reviewed
Apr 26, 2021
t3chguy
reviewed
Apr 26, 2021
t3chguy
reviewed
Apr 26, 2021
turt2live
reviewed
Apr 26, 2021
turt2live
reviewed
Apr 26, 2021
dbkr
approved these changes
Apr 27, 2021
germain-gg
force-pushed
the
gsouquet-i18n-td
branch
from
April 27, 2021 14:10
52a00ae
to
e64e6e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes element-hq/element-web#16854
To review at the same time as this pull request
Outstanding tasks before closing this pull request
element-web
element-desktop
pipeline to rundiff-i18n
scriptDescription
This project now supports internationalisation. It largely reuses the i18n setup in
element-web
.It is worth noting that I have added a lot of
label
insrc/vectormenu.js
. This is to provide a consistent translation experience to users that have a different locale setup on their OS and on Element.