Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all read receipt avatars from thread view #5239

Closed
ismailgulek opened this issue Dec 2, 2021 · 1 comment · Fixed by #5257
Closed

Remove all read receipt avatars from thread view #5239

ismailgulek opened this issue Dec 2, 2021 · 1 comment · Fixed by #5257
Assignees
@ismailgulek
Labels
A-Threads Message threading to simplify the Timeline Z-Labs Z-ThreadsInternalTesting Issue found while testing Threads internally Z-ThreadsP0 The first milestone for Threads

Comments

@ismailgulek
Copy link
Contributor

Because threads implementation reuses RoomViewController and RoomDataSource, read receipt avatars are displayed in a thread view as well. This is not intended for threads P0 release, they need to be removed from thread views.
@ismailgulek ismailgulek added the A-Threads Message threading to simplify the Timeline label Dec 2, 2021
@ismailgulek ismailgulek self-assigned this Dec 2, 2021
@daniellekirkwood daniellekirkwood added the Z-ThreadsP0 The first milestone for Threads label Dec 2, 2021
ismailgulek added a commit that referenced this issue Dec 8, 2021
@ismailgulek
Hide read receipt avatars on threads, fix #5239
e593422
@ismailgulek ismailgulek linked a pull request Dec 10, 2021 that will close this issue
Thread Notifications & Badges #5257
Merged
@daniellekirkwood
Copy link
Contributor

This was raised by @janogarcia as a "fail" in the January 21, 2022 testing round

@daniellekirkwood daniellekirkwood added the Z-ThreadsInternalTesting Issue found while testing Threads internally label Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ismailgulek ismailgulek

Labels
A-Threads Message threading to simplify the Timeline Z-Labs Z-ThreadsInternalTesting Issue found while testing Threads internally Z-ThreadsP0 The first milestone for Threads
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Thread Notifications & Badges element-hq/element-ios
2 participants
@ismailgulek @daniellekirkwood