Group details: Add Rooms page #1717
Conversation
| - (void)cancelRegistrationOnGroupChangeNotifications | ||
| { | ||
| // Remove any pending observers | ||
| [[NSNotificationCenter defaultCenter] removeObserver:self]; |
There was a problem hiding this comment.
That kills the listener on kRiotDesignValuesDidChangeThemeNotification too.
There was a problem hiding this comment.
@manuroe after checking it. I disagree, the kRiotDesignValuesDidChangeThemeNotification observer is not remove here. But I will update the code to remove only the listeners on group update
There was a problem hiding this comment.
ok. I am going to merge the PR as is. Note that there is same behavior in GroupParticipantsViewController and GroupHomeViewController
| // Update here the displayed group instance with the one stored in the session (if any). | ||
| MXGroup *group = [self.mxSession groupWithGroupId:_group.groupId]; | ||
|
|
||
| [self refreshDisplayWithGroup:(group ? group : _group)]; |
There was a problem hiding this comment.
Does it worth to update if the updated group is not the current one?
There was a problem hiding this comment.
I decided here to keep up to date the displayed information of the group even if the update has been observed/triggered on another instance of the group
There was a problem hiding this comment.
ack (this comment is in fact an hidden test for push notifications testing)
| } | ||
| } | ||
|
|
||
| - (void)startActivityIndicator |
There was a problem hiding this comment.
The activity indicator is not used for the moment (this is just a notice)
There was a problem hiding this comment.
agree, I kept it because it will be used when we will enable the admin to remove rooms
element-hq/riot-meta#117