Add ReCaptcha screen #6135
Merged
Add ReCaptcha screen #6135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixlwave
changed the base branch from
develop
to
doug/5649_auth_email_verification
pixlwave
requested review from
a team,
SBiOSoftWhare,
ismailgulek and
aringenbach
and removed request for
a team and
ismailgulek
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/H3rJAN |
SBiOSoftWhare
approved these changes
May 10, 2022
Support dark mode in MXKAuthenticationRecaptchaWebView. Begin implementing the ReCaptcha coordinator.
pixlwave
force-pushed
the
doug/5650_auth_captcha
branch
from
73355a3
to
ed9cbe0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the views, but it isn't yet part of the flow and the coordinator only has an initial implementation so far. Additionally this PR adds support for dark mode to the
MXKAuthenticationReCaptchaWebView.Note: Voiceover only partially works on the ReCaptcha form and Dynamic Type doesn't seem to work at all. There is also potentially more work required to get the sizing of the form to be optimal on a larger range of devices.
Part of issue #5650
Fixes #6054