Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very old events appear out of order in the live timeline after federation backfill #1491

Open
matrixbot opened this issue Apr 24, 2016 · 12 comments
Labels
A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Spec-Changes

Comments

@matrixbot
Copy link

matrixbot commented Apr 24, 2016

Created by @ richvdh:sw1v.org.

when synapse decides to backfill get_missing_events events over federation, these end up being sent to clients over /sync, which leads to very confusing timelines with old messages

@ara4n ara4n changed the title very old events appear in the live timeline Very old events appear in the live timeline after federation backfill Apr 28, 2016
@ara4n ara4n added T-Defect P1 S-Minor Impairs non-critical functionality or suitable workarounds exist labels Apr 28, 2016
@ara4n
Copy link
Member

ara4n commented Apr 28, 2016

element-hq/element-web#897 might be related?

@richvdh
Copy link
Member

richvdh commented Jun 7, 2016

yes, they sound like duplicates

@richvdh
Copy link
Member

richvdh commented Oct 11, 2016

... so let's close this one.

@richvdh richvdh closed this as completed Oct 11, 2016
@richvdh
Copy link
Member

richvdh commented Oct 11, 2016

Hrm, I'm not convinced they are dups

@richvdh richvdh reopened this Oct 11, 2016
@ara4n ara4n changed the title Very old events appear in the live timeline after federation backfill Very old events appear out of order in the live timeline after federation backfill Dec 30, 2016
@ara4n
Copy link
Member

ara4n commented Dec 30, 2016

This is getting really nasty with federation glitches recently. It'd almost be better to drop events with ancient timestamps than append them to the live timeline.

@jfrederickson
Copy link

I'd say drop events with ancient timestamps if the surrounding events aren't in the current timeline view, otherwise insert them in the correct place in the timeline.

Possible gotcha: a malicious homeserver could forge an event that appears to have been sent in the past. (But maybe that's already possible and they look like older events after a refresh?)

@ara4n
Copy link
Member

ara4n commented Jan 4, 2017

in terms of UI for when old messages flood in: how about showing up a /!\ status prompt saying "you received old messages from <a href="permalink">timestamp</a>"?

@erdnaxeli
Copy link

Put the event at the correct location and add a banner would be better. But as a user I probably don't care about this event. This is instant messaging, I will not react to a message 3 pages back (it's not really about time but the quantity of messages).

@t3chguy
Copy link
Member

t3chguy commented Aug 16, 2017

Riot likely does not have events that far back to be able to put it at the correct location

@erdnaxeli
Copy link

Sometime it does, see the attached screenshot of what happened today to me. I suppose when it don't, Riot should just drop the event.

2017-08-16-140317_1920x1080_scrot

@turt2live
Copy link
Member

This is effectively impossible for the client to fix on its own - it will need some sort of spec fix, possibly from Sliding Sync or being able to identify gaps in the timeline.

@turt2live turt2live added X-Spec-Changes O-Occasional Affects or can be seen by some users regularly or most users rarely and removed P1 labels Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Spec-Changes
Projects
None yet
Development

No branches or pull requests

8 participants