Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird messed up timeline when joining a room for the first time #897

Closed
AmandineLP opened this issue Feb 9, 2016 · 11 comments
Closed

Weird messed up timeline when joining a room for the first time #897

AmandineLP opened this issue Feb 9, 2016 · 11 comments
Assignees
Labels
P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@AmandineLP
Copy link
Contributor

I joined the room by clicking on it from the directory. No messages were exchanged before, only statuses. Xena is admin and on Matrix.org. Refreshing fixes it

image

@AmandineLP
Copy link
Contributor Author

it happened again...

image

@ara4n ara4n added T-Defect P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Feb 14, 2016
@ara4n ara4n changed the title Weird messed up timeline when joining a room Weird messed up timeline when joining a room for the first time Feb 14, 2016
@ara4n
Copy link
Member

ara4n commented Feb 14, 2016

@erikjohnston this looks worryingly like the HS coughing up ancient events?

@erikjohnston
Copy link
Member

I think the last one might be a federation thing (where we hadn't gotten the join before), and a different bug from the first.

@erikjohnston
Copy link
Member

So, I can't see anything obvious that would explain this behaviour server side. I think at this point I kinda need the /sync and /messages responses, which I appreciate might be hard to get.

Is there any possibility that vector has incorrectly ordered the responses to multiple /message requests? Alternatively, synapse will send down those events in the state section of /sync?

@ara4n
Copy link
Member

ara4n commented Mar 2, 2016

@dbkr: is there any chance this is related to the multiple concurrent
/sync bug you hit?

On 02/03/2016 16:15, Erik Johnston wrote:

So, I can't see anything obvious that would explain this behaviour
server side. I think at this point I kinda need the |/sync| and
|/messages| responses, which I appreciate might be hard to get.

Is there any possibility that vector has incorrectly ordered the
responses to multiple |/message| requests? Alternatively, synapse
will send down those events in the state section?

— Reply to this email directly or view it on GitHub
#897 (comment).

@richvdh
Copy link
Member

richvdh commented Mar 11, 2016

I suspect this is something to do with changes in history_visibility; in particular, events that have shared history_visibility which become visible when you join. But still, it's hard to see why old events would be stuck at the end of the timeline. It would be very useful to have the /events / /sync / /messages requests from this time.

@richvdh
Copy link
Member

richvdh commented Mar 11, 2016

@ara4n ara4n added this to the v2 - Public Preview milestone Apr 13, 2016
@richvdh richvdh changed the title Weird messed up timeline when joining a room for the first time Very old events appear in the live timeline after federation backfill Oct 11, 2016
@richvdh richvdh changed the title Very old events appear in the live timeline after federation backfill Weird messed up timeline when joining a room for the first time Oct 11, 2016
@richvdh
Copy link
Member

richvdh commented Oct 11, 2016

This bug, in its original guise (messed up timeline on room join), doesn't seem to have been seen for a while. (As opposed to element-hq/element-meta#1491, which is some sort of screwup which happens when synapse decides to backfill an existing room over federation, and is definitely still happening). Is it possible it's gone away?

@ara4n
Copy link
Member

ara4n commented Oct 11, 2016

yeah, unless @AmandineLP has seen it again (given she seems to be the main progenitor), i think this has been fixed somehow somewhere. Perhaps @erikjohnston might even know where.

@AmandineLP
Copy link
Contributor Author

I haven't seen it recently

@ara4n
Copy link
Member

ara4n commented Dec 21, 2016

KILL IT WITH FIRE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Development

No branches or pull requests

4 participants