Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Soft logout: Rehydrate session from soft logout page #10236

Closed
turt2live opened this issue Jul 2, 2019 · 4 comments · Fixed by matrix-org/matrix-react-sdk#3182
Closed

Soft logout: Rehydrate session from soft logout page #10236

turt2live opened this issue Jul 2, 2019 · 4 comments · Fixed by matrix-org/matrix-react-sdk#3182
Assignees
@turt2live
Labels
A-Soft-Logout https://github.com/element-hq/element-web/issues/10224 P1 T-Enhancement

Comments

@turt2live
Copy link
Member

Depends on #10235
@turt2live turt2live added feature P1 A-Soft-Logout https://github.com/element-hq/element-web/issues/10224 labels Jul 2, 2019
This was referenced Jul 2, 2019
Closed
Closed
@turt2live turt2live changed the title Soft logout: Disable and prefill login form when going from soft logout Soft logout: Disable and prefill login form when going from soft logout & rehydrate session Jul 3, 2019
@turt2live
Copy link
Member Author

Re-hydrating the session is a bit non-trivial for #10235, so using this issue to track it.

turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 3, 2019
@turt2live
Implement basic soft logout handling
42e6287 
Fixes element-hq/element-web#10235

CSS and copy are left as an exercise for a later iteration.

Login page handling is left for element-hq/element-web#10236

This implementation reuses as much of the Lifecycle flow as it can without causing problems. Most importantly, it requires matrix-org/matrix-js-sdk#975 to be able to detect a soft logout and react to it. When it comes time to starting/stopping the Lifecycle, additional parameters are provided so that the auxiliary services can (re)start themselves without the client starting to sync.
@turt2live turt2live mentioned this issue Jul 3, 2019
Merged
@turt2live turt2live self-assigned this Jul 3, 2019
@turt2live turt2live added phase:1 and removed phase:1 labels Jul 4, 2019
@turt2live turt2live changed the title Soft logout: Disable and prefill login form when going from soft logout & rehydrate session Soft logout: Rehydrate session from soft logout page Jul 4, 2019
@turt2live
Copy link
Member Author

Hijacking this for our new design which is essentially an embedded login page rather than navigating elsewhere.

@turt2live
Copy link
Member Author

SSO deferred to #10238

@nadonomy
Copy link
Contributor

nadonomy commented Jul 4, 2019

Latest Zeplin: https://zpl.io/a89QL5x

turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 4, 2019
@turt2live
Ask for the user's password to rehydrate their soft logged out session
93872e6 
Fixes element-hq/element-web#10236

The changes to the MatrixClientPeg (assign/start) are to permit the SoftLogout page to access the MatrixClientPeg reliably. This is why assign() is called by Lifecycle as an alternative to start().

Minimal design work has been done here. The majority is deferred to element-hq/element-web#10262
@turt2live turt2live mentioned this issue Jul 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
A-Soft-Logout https://github.com/element-hq/element-web/issues/10224 P1 T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ask for the user's password to rehydrate their soft logged out session matrix-org/matrix-react-sdk
3 participants
@jryans @turt2live @nadonomy