Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solid color squares shown instead of emoji in 1.2.2 and 1.2.3 (Mac Desktop version) #10296

Closed
lascapi opened this issue Jul 9, 2019 · 11 comments · Fixed by #10392
Closed

Solid color squares shown instead of emoji in 1.2.2 and 1.2.3 (Mac Desktop version) #10296

lascapi opened this issue Jul 9, 2019 · 11 comments · Fixed by #10392
Labels
A-Electron A-Emoji T-Defect X-Needs-Info This issue is blocked awaiting information from the reporter

Comments

@lascapi
Copy link

lascapi commented Jul 9, 2019

Hi, I found an issue, similar to #10143 :

Solid color squares shown instead of emoji in 1.2.2, worked in 1.2.1.

The emoji is actually there but isn't displayed correctly; copying it to another program makes it show up correctly over there.

  • Intall the Desktop Application for Mac
  • open a discution with emoji on
  • there is square and not emoji

On the app
riot-desktop
On Firefox
riot-web

Other Unicode like chinese characters seems to be good.

Version information

For the desktop app:

  • OS: macOS 10.11
  • Version: 1.2.2 and 1.2.3
@jryans
Copy link
Collaborator

jryans commented Jul 10, 2019

This is a complex tale of various libraries and versions:

  • Riot 1.2.3 desktop uses Electron 4.2.6
  • Electron 4.2.6 is built on Chromium 69
  • Full COLR support regardless of OS support was (probably) enabled with Chromium 71
  • When Riot loads, it detects COLR support as not available, so it loads the SBIX fallback fonts
  • For some reason, the SBIX version is apparently being chosen by font selection even though it doesn't draw correct glyphs for you

Can you open the DevTools in Riot (Cmd-Opt-I), go to the Network tab, select the Font filter, reload the app with Cmd-R, and take a screenshot / copy a list of the font files loaded?

@jryans
Copy link
Collaborator

jryans commented Jul 10, 2019

(Electron 5.0.6 is built on Chromium 73, so this could become a strong reason to upgrade.)

@jryans jryans added the X-Needs-Info This issue is blocked awaiting information from the reporter label Jul 10, 2019
@lascapi
Copy link
Author

lascapi commented Jul 10, 2019

Hi, there is fonts :

Nunito-Regular.ffae5d0.ttf 200 font Tinter.js:248 (from memory cache) 0 ms
Nunito-SemiBold.da07a44.ttf 200 font Tinter.js:248 (from memory cache) 0 ms
Nunito-Bold.f7e8fbd.ttf 200 font Tinter.js:248 (from memory cache) 0 ms
QldKNThLqRwH-OJ1UHjlKGlZ5qhExfHw.5476fd3.woff2 200 font Tinter.js:248 (from memory cache) 0 ms
TwemojiMozilla-sbix.661486d.woff2 200 font ScrollPanel.js:731 0 B 1.34 s

riot-font

@noplanman
Copy link

I've got the same issue, slightly different fonts though:
riot-web-fonts

@jryans
Copy link
Collaborator

jryans commented Jul 19, 2019

@lascapi @noplanman Thanks for attaching the network details.

Let's try one more test. I'd like to see the result of the test site https://pixelambacht.nl/chromacheck/ inside the Riot app for you.

Here's a way to achieve that:

  1. Open DevTools in Riot (Cmd-Opt-I)
  2. Go to Console tab
  3. Enter location.href = "https://pixelambacht.nl/chromacheck/"
  4. Capture a screenshot of the result
  5. Enter history.back() to go back to Riot

@noplanman
Copy link

noplanman commented Jul 19, 2019

riot-supported-fonts

@jryans
Copy link
Collaborator

jryans commented Jul 19, 2019

Hmm, but SBIX very plainly is not supported in reality... 😭 I'll try to think about what could be done here.

jryans added a commit that referenced this issue Jul 22, 2019
The APIs related to custom protocols went through some changes for Electron 5.x,
so adjusts Riot's usages to match.

I have scanned the Electron 5.x release notes, and I can't see anything else
that requires immediate changes. Things appear to be working well after the
upgrade.

Fixes #10296
Fixes #9562
@jryans
Copy link
Collaborator

jryans commented Jul 23, 2019

I have upgraded Riot to Electron 5, which I am hoping will fix this issue.

If you are feeling adventurous, you could try to build the develop branch of Riot to see whether it fixes this for you. Our next stable release of Riot will use Electron 5, so you can also wait for that (should be in the next few weeks).

@noplanman
Copy link

@jryans Hope it's ok to pop the question here, but is there an easy way to build the electron app using the docker image from the develop branch? Because it's the electron app that needs the testing, the web version works fine.

@turt2live
Copy link
Member

@noplanman you don't need Docker to build the electron image. There's some instructions in the readme, however the steps are roughly: yarn install electron@5 && yarn build && yarn electron and it should give you an electron to test with (not installed over top, just long enough to verify the problem is fixed).

@noplanman
Copy link

Thanks @turt2live, thought it was more involved, but turned out to be super simple 🎉

Latest dev brings back the Emojis, awesome @jryans 💪

su-ex added a commit to SchildiChat/element-web that referenced this issue Mar 15, 2023
* Remove experimental PWA support for Firefox and Safari ([\element-hq#24630](element-hq#24630)).
* Only allow to start a DM with one email if encryption by default is enabled ([\element-hq#10253](matrix-org/matrix-react-sdk#10253)). Fixes element-hq#23133.
* DM rooms are now encrypted if encryption by default is enabled and only inviting a single email address. Any action in the result DM room will be blocked until the other has joined. ([\element-hq#10229](matrix-org/matrix-react-sdk#10229)).
* Reduce bottom margin of ReplyChain on compact modern layout ([\element-hq#8972](matrix-org/matrix-react-sdk#8972)). Fixes element-hq#22748. Contributed by @luixxiul.
* Support for v2 of MSC3903 ([\element-hq#10165](matrix-org/matrix-react-sdk#10165)). Contributed by @hughns.
* When starting a DM, existing rooms with pending third-party invites will be reused. ([\element-hq#10256](matrix-org/matrix-react-sdk#10256)). Fixes element-hq#23139.
* Polls push rules: synchronise poll rules with message rules ([\element-hq#10263](matrix-org/matrix-react-sdk#10263)). Contributed by @kerryarchibald.
* New verification request toast button labels ([\element-hq#10259](matrix-org/matrix-react-sdk#10259)).
* Remove padding around integration manager iframe ([\#10148](matrix-org/matrix-react-sdk#10148)).
* Fix block code styling in rich text editor ([\element-hq#10246](matrix-org/matrix-react-sdk#10246)). Contributed by @alunturner.
* Poll history: fetch more poll history ([\element-hq#10235](matrix-org/matrix-react-sdk#10235)). Contributed by @kerryarchibald.
* Sort short/exact emoji matches before longer incomplete matches ([\element-hq#10212](matrix-org/matrix-react-sdk#10212)). Fixes element-hq#23210. Contributed by @grimhilt.
* Poll history: detail screen ([\element-hq#10172](matrix-org/matrix-react-sdk#10172)). Contributed by @kerryarchibald.
* Provide a more detailed error message than "No known servers" ([\element-hq#6048](matrix-org/matrix-react-sdk#6048)). Fixes element-hq#13247. Contributed by @aaronraimist.
* Say when a call was answered from a different device ([\element-hq#10224](matrix-org/matrix-react-sdk#10224)).
* Widget permissions customizations using module api ([\element-hq#10121](matrix-org/matrix-react-sdk#10121)). Contributed by @maheichyk.
* Fix copy button icon overlapping with copyable text ([\element-hq#10227](matrix-org/matrix-react-sdk#10227)). Contributed by @Adesh-Pandey.
* Support joining non-peekable rooms via the module API ([\element-hq#10154](matrix-org/matrix-react-sdk#10154)). Contributed by @maheichyk.
* The "new login" toast does now display the same device information as in the settings. "No" does now open the device settings. "Yes, it was me" dismisses the toast. ([\element-hq#10200](matrix-org/matrix-react-sdk#10200)).
* Do not prompt for a password when doing a „reset all“ after login ([\element-hq#10208](matrix-org/matrix-react-sdk#10208)).
* Fix incorrect copy in space creation flow ([\element-hq#10296](matrix-org/matrix-react-sdk#10296)). Fixes element-hq#24741.
* Fix space settings dialog having rogue title tooltip ([\element-hq#10293](matrix-org/matrix-react-sdk#10293)). Fixes element-hq#24740.
* Show spinner when starting a DM from the user profile (right panel) ([\element-hq#10290](matrix-org/matrix-react-sdk#10290)).
* Reduce height of toggle on expanded view source event ([\element-hq#10283](matrix-org/matrix-react-sdk#10283)). Fixes element-hq#22873. Contributed by @luixxiul.
* Pillify http and non-prefixed matrix.to links ([\element-hq#10277](matrix-org/matrix-react-sdk#10277)). Fixes element-hq#20844.
* Fix some features not being configurable via `features` ([\element-hq#10276](matrix-org/matrix-react-sdk#10276)).
* Fix starting a DM from the right panel in some cases ([\element-hq#10278](matrix-org/matrix-react-sdk#10278)). Fixes element-hq#24722.
* Align info EventTile and normal EventTile on IRC layout ([\element-hq#10197](matrix-org/matrix-react-sdk#10197)). Fixes element-hq#22782. Contributed by @luixxiul.
* Fix blowout of waveform of the voice message player on narrow UI ([\element-hq#8861](matrix-org/matrix-react-sdk#8861)). Fixes element-hq#22604. Contributed by @luixxiul.
* Fix the hidden view source toggle on IRC layout ([\element-hq#10266](matrix-org/matrix-react-sdk#10266)). Fixes element-hq#22872. Contributed by @luixxiul.
* Fix buttons on the room header being compressed due to long room name ([\element-hq#10155](matrix-org/matrix-react-sdk#10155)). Contributed by @luixxiul.
* Use the room avatar as a placeholder in calls ([\element-hq#10231](matrix-org/matrix-react-sdk#10231)).
* Fix calls showing as 'connecting' after hangup ([\element-hq#10223](matrix-org/matrix-react-sdk#10223)).
* Prevent multiple Jitsi calls started at the same time ([\element-hq#10183](matrix-org/matrix-react-sdk#10183)). Fixes element-hq#23009.
* Make localization keys compatible with agglutinative and/or SOV type languages ([\element-hq#10159](matrix-org/matrix-react-sdk#10159)). Contributed by @luixxiul.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Electron A-Emoji T-Defect X-Needs-Info This issue is blocked awaiting information from the reporter
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants