Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post-login cross-signing setup flow #11214

Closed
dbkr opened this issue Oct 24, 2019 · 0 comments · Fixed by matrix-org/matrix-react-sdk#3847
Closed

Post-login cross-signing setup flow #11214

dbkr opened this issue Oct 24, 2019 · 0 comments · Fixed by matrix-org/matrix-react-sdk#3847
Assignees
@jryans
Labels
A-E2EE-Cross-Signing

Comments

@dbkr
Copy link
Member

dbkr commented Oct 24, 2019

Implement the new screens for the post-login security set up flow (which sets up cross signing and key backup).

We can't just directly stick this behind the labs flag since the idea is it pops up on login so you'd have to set the labs flag in your client config. Instead, let's:

  • If the cross-signing labs flag is on and the user does not have cross-signing keys on their account, add a 'Experimental: setup cross-signing' button in the key backup section to start the initial setup flow. This is just temporary UI for development.
  • If the cross-signing labs flag is on and the user does have cross-signing keys on their account, just show 'cross-signing enabled' text or something. Again this is temporary.
  • On login, start the flow if the user has cross-signing keys on their account, but only support setup by entering recovery keys at this stage.
  • This probably may as well be completely separate screens from the key backup screens: they're fairly substantially different, and this lets us keep everything as-is with the labs flag disabled.
@dbkr dbkr changed the title Cross-signing setup flow Initial cross-signing setup flow Oct 24, 2019
This was referenced Oct 24, 2019
Closed
Closed
Open
@jryans jryans changed the title Initial cross-signing setup flow Post-login cross-signing setup flow Dec 9, 2019
@jryans jryans self-assigned this Jan 3, 2020
jryans added a commit to matrix-org/matrix-js-sdk that referenced this issue Jan 15, 2020
@jryans
Add API to get account data from server
c5c27b3 
This adds an API account data getter that bypasses the local store and goes
directly to the homeserver.

Part of element-hq/element-web#11214
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Jan 15, 2020
@jryans
Add post-login complete security flow
27ee90c 
This adds a step after login to complete security for your new session. At the
moment, the only verification method is entering your SSSS passphrase, but nicer
paths will be added soon.

This new step only appears when crypto is available and the account has
cross-signing enabled in SSSS.

Fixes element-hq/element-web#11214
This was referenced Jan 15, 2020
Merged
Merged
jryans added a commit that referenced this issue Jan 16, 2020
@jryans
Remove spinner check
fb77bcf 
We may no longer see a spinner for some login paths with the changes to add a
complete security step.

Part of #11214
@jryans jryans mentioned this issue Jan 16, 2020
Merged
@jryans jryans added the phase:1 label Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-E2EE-Cross-Signing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add post-login complete security flow matrix-org/matrix-react-sdk
3 participants
@jryans @dbkr @lampholder