Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAS cross-signing js-sdk test is broken #11545

Closed
turt2live opened this issue Nov 28, 2019 · 0 comments · Fixed by matrix-org/matrix-js-sdk#1096
Closed

SAS cross-signing js-sdk test is broken #11545

turt2live opened this issue Nov 28, 2019 · 0 comments · Fixed by matrix-org/matrix-js-sdk#1096
Assignees
@uhoreg
Labels
A-E2EE-Cross-Signing P1 T-Defect T-Task Tasks for the team like planning

Comments

@turt2live
Copy link
Member

We should fix this before releasing cross-signing for real.
turt2live added a commit to matrix-org/matrix-js-sdk that referenced this issue Nov 28, 2019
@turt2live
Disable broken cross-signing test
aee9442 
I don't know why it's broken, but the two errors I can get out of it are "unknown device for verification" and "user_signing key does not match". Someone who knows a bit more about cross-signing will probably need to take a look at this one.

Fixes element-hq/element-web#11520 (technically)
Opened element-hq/element-web#11545 to fix this correctly.
@turt2live turt2live mentioned this issue Nov 28, 2019
Merged
@jryans jryans added story:1 and removed phase:1 labels Nov 28, 2019
@uhoreg uhoreg self-assigned this Nov 28, 2019
@uhoreg uhoreg mentioned this issue Nov 28, 2019
Merged
@jryans jryans added the phase:1 label Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@uhoreg uhoreg

Labels
A-E2EE-Cross-Signing P1 T-Defect T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

increase timeout on flush to fix failing unit test uhoreg/matrix-js-sdk
3 participants
@jryans @uhoreg @turt2live