Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pinned messages don't update with edits #17098

Closed
HarHarLinks opened this issue Apr 28, 2021 · 6 comments · Fixed by matrix-org/matrix-react-sdk#7920
Closed

Pinned messages don't update with edits #17098

HarHarLinks opened this issue Apr 28, 2021 · 6 comments · Fixed by matrix-org/matrix-react-sdk#7920
Assignees
@robintown
Labels
A-Message-Editing A-Message-Pinning T-Defect Z-Labs

Comments

@HarHarLinks
Copy link
Contributor

Description

2021 evolution of #5358, possibly related.

Steps to reproduce

  • encrypted room
  • post message, edit message
  • pin message
  • edit some more

pin view shows the edited message at the time of pinning (including * etc), not the subsequent edits.
please also make it pretty and consistent with the regular view, e.g. (edited) and stuff.

Logs being sent: no

Version information

  • Platform: desktop

For the desktop app:

  • OS: Arch
  • Version: aur/element-desktop-nightly-bin 2021042701-1
@SimonBrandner
Copy link
Contributor

Peek 2021-05-02 20-17

I can't repro. Am I following the steps correctly? Can you safely repro?

@HarHarLinks
Copy link
Contributor Author

HarHarLinks commented May 3, 2021 •
edited
Loading

  1. the original issue does seem to have disappeared, I'm now on nightly 2021042901-1. the issue may have appeared because the editing happened not immediately like in the tests, but only several pages of chat later so it may have to do with the usual pinning issue of losing pins that are too far back in (unloaded) history. however I think that shouldn't only be supported for completeness, but also this is actually a common occurrence for pins. i'll keep an eye on a longer term test.
  2. in your test, you show the need to refresh pins manually. imo the pinned message should automatically update

@HarHarLinks
Copy link
Contributor Author

I found the original message that prompted me to open this issue (actually i think element loaded enough history after a while to make it appear in pins). it has seen 5 edits (it is a list that got ticked off over the course of a day). currently both the message and the pin do not show the latest edit(!), however the edit history does.

i have not been able to repro yet.

@t3chguy
Copy link
Member

t3chguy commented Jul 12, 2021

Nique reproduced this in our DM

image

@kittykat kittykat added the Z-Labs label Dec 8, 2021
@robintown robintown self-assigned this Feb 28, 2022
@robintown
Copy link
Member

I've investigated this a bit, and it should at least be solvable for unencrypted rooms via the /relations API, but missing edits in encrypted rooms seems a bit unavoidable given the lack of server-side aggregations. Threads seem to suffer from the same issue in encrypted rooms, FTR.

@robintown
Copy link
Member

Apparently I misremembered—aggregations work in encrypted rooms too since relations are unencrypted, so this should be a straightforward fix.

@robintown robintown mentioned this issue Feb 28, 2022
Merged
su-ex added a commit to SchildiChat/element-desktop that referenced this issue Mar 17, 2022
@su-ex
Merge tag 'v1.10.7' into sc
054bb16 
* Fix a bug where URL previews could be enabled in the left-panel when they
should not have been.
* Add a config.json option to skip the built-in Jitsi welcome screen ([\#21190](element-hq/element-web#21190)).
* Add unexposed account setting for hiding poll creation ([\#7972](matrix-org/matrix-react-sdk#7972)).
* Allow pinning polls ([\#7922](matrix-org/matrix-react-sdk#7922)). Fixes element-hq/element-web#20152.
* Make trailing `:` into a setting ([\#6711](matrix-org/matrix-react-sdk#6711)). Fixes element-hq/element-web#16682. Contributed by @SimonBrandner.
* Location sharing > back button ([\#7958](matrix-org/matrix-react-sdk#7958)).
* use LocationAssetType ([\#7965](matrix-org/matrix-react-sdk#7965)).
* Location share type UI ([\#7924](matrix-org/matrix-react-sdk#7924)).
* Add a few more UIComponent flags, and ensure they are used in existing code ([\#7937](matrix-org/matrix-react-sdk#7937)).
* Add support for overriding strings in the app ([\#7886](matrix-org/matrix-react-sdk#7886)).
* Add support for redirecting to external pages after logout ([\#7905](matrix-org/matrix-react-sdk#7905)).
* Expose redaction power level in room settings ([\#7599](matrix-org/matrix-react-sdk#7599)). Fixes element-hq/element-web#20590. Contributed by @SimonBrandner.
* Update and expand ways to access pinned messages ([\#7906](matrix-org/matrix-react-sdk#7906)). Fixes element-hq/element-web#21209 and element-hq/element-web#21211.
* Add slash command to switch to a room's virtual room ([\#7839](matrix-org/matrix-react-sdk#7839)).
* Remove Lojban translation ([\#21302](element-hq/element-web#21302)).
* Merge pull request from GHSA-qmf4-7w7j-vf23 ([\#8059](matrix-org/matrix-react-sdk#8059)).
* Add another null guard for member ([\#7984](matrix-org/matrix-react-sdk#7984)). Fixes element-hq/element-web#21319.
* Fix room account settings ([\#7999](matrix-org/matrix-react-sdk#7999)).
* Fix missing summary text for pinned message changes ([\#7989](matrix-org/matrix-react-sdk#7989)). Fixes element-hq/element-web#19823.
* Pass room to getRoomTombstone to avoid racing with setState ([\#7986](matrix-org/matrix-react-sdk#7986)).
* Hide composer and call buttons when the room is tombstoned ([\#7975](matrix-org/matrix-react-sdk#7975)). Fixes element-hq/element-web#21286.
* Fix bad ternary statement in autocomplete user pill insertions ([\#7977](matrix-org/matrix-react-sdk#7977)). Fixes element-hq/element-web#21307.
* Fix sending locations into threads and fix i18n ([\#7943](matrix-org/matrix-react-sdk#7943)). Fixes element-hq/element-web#21267.
* Fix location map attribution rendering over message action bar ([\#7974](matrix-org/matrix-react-sdk#7974)). Fixes element-hq/element-web#21297.
* Fix wrongly asserting that PushRule::conditions is non-null ([\#7973](matrix-org/matrix-react-sdk#7973)). Fixes element-hq/element-web#21305.
* Fix account & room settings race condition ([\#7953](matrix-org/matrix-react-sdk#7953)). Fixes element-hq/element-web#21163.
* Fix bug with some space selections not being applied ([\#7971](matrix-org/matrix-react-sdk#7971)). Fixes element-hq/element-web#21290.
* Revert "replace all require(.svg) with esm import" ([\#7969](matrix-org/matrix-react-sdk#7969)). Fixes element-hq/element-web#21293.
* Hide unpinnable pinned messages in more cases ([\#7921](matrix-org/matrix-react-sdk#7921)).
* Fix room list being laggy while scrolling 🐌 ([\#7939](matrix-org/matrix-react-sdk#7939)). Fixes element-hq/element-web#21262.
* Make pinned messages more reliably reflect edits ([\#7920](matrix-org/matrix-react-sdk#7920)). Fixes element-hq/element-web#17098.
* Improve accessibility of the BetaPill ([\#7949](matrix-org/matrix-react-sdk#7949)). Fixes element-hq/element-web#21255.
* Autofocus correct composer after sending reaction ([\#7950](matrix-org/matrix-react-sdk#7950)). Fixes element-hq/element-web#21273.
* Consider polls as message events for rendering redactions ([\#7944](matrix-org/matrix-react-sdk#7944)). Fixes element-hq/element-web#21125.
* Prevent event tiles being shrunk/collapsed by flexbox ([\#7942](matrix-org/matrix-react-sdk#7942)). Fixes element-hq/element-web#21269.
* Fix ExportDialog title on export cancellation ([\#7936](matrix-org/matrix-react-sdk#7936)). Fixes element-hq/element-web#21260. Contributed by @luixxiul.
* Mandate use of js-sdk/src/matrix import over js-sdk/src ([\#7933](matrix-org/matrix-react-sdk#7933)). Fixes element-hq/element-web#21253.
* Fix backspace not working in the invite dialog ([\#7931](matrix-org/matrix-react-sdk#7931)). Fixes element-hq/element-web#21249. Contributed by @SimonBrandner.
* Fix right panel soft crashes due to missing room prop ([\#7923](matrix-org/matrix-react-sdk#7923)). Fixes element-hq/element-web#21243.
* fix color of location share caret ([\#7917](matrix-org/matrix-react-sdk#7917)).
* Wrap all EventTiles with a TileErrorBoundary and guard parsePermalink ([\#7916](matrix-org/matrix-react-sdk#7916)). Fixes element-hq/element-web#21216.
* Fix changing space sometimes bouncing to the wrong space ([\#7910](matrix-org/matrix-react-sdk#7910)). Fixes element-hq/element-web#20425.
* Ensure EventListSummary key does not change during backpagination ([\#7915](matrix-org/matrix-react-sdk#7915)). Fixes element-hq/element-web#9192.
* Fix positioning of the thread context menu ([\#7918](matrix-org/matrix-react-sdk#7918)). Fixes element-hq/element-web#21236.
* Inject sender into pinned messages ([\#7904](matrix-org/matrix-react-sdk#7904)). Fixes element-hq/element-web#20314.
* Tweak info message padding in right panel timeline ([\#7901](matrix-org/matrix-react-sdk#7901)). Fixes element-hq/element-web#21212.
* Fix another freeze on room switch ([\#7900](matrix-org/matrix-react-sdk#7900)). Fixes element-hq/element-web#21127.
* Clean up error listener when location picker closes ([\#7902](matrix-org/matrix-react-sdk#7902)). Fixes element-hq/element-web#21213.
* Fix edge case in context menu chevron positioning ([\#7899](matrix-org/matrix-react-sdk#7899)).
* Fix composer format buttons on WebKit ([\#7898](matrix-org/matrix-react-sdk#7898)). Fixes element-hq/element-web#20868.
* manage voicerecording state when deleting or sending a voice message ([\#7896](matrix-org/matrix-react-sdk#7896)). Fixes element-hq/element-web#21151.
* Fix bug with useRoomHierarchy tight-looping loadMore on error ([\#7893](matrix-org/matrix-react-sdk#7893)).
* Fix upload button & shortcut not working for narrow composer mode ([\#7894](matrix-org/matrix-react-sdk#7894)). Fixes element-hq/element-web#21175 and element-hq/element-web#21142.
* Fix emoji insertion in thread composer going to the main composer ([\#7895](matrix-org/matrix-react-sdk#7895)). Fixes element-hq/element-web#21202.
* Try harder to keep context menus inside the window ([\#7863](matrix-org/matrix-react-sdk#7863)). Fixes element-hq/element-web#17527 and element-hq/element-web#18377.
* Fix edge case around event list summary layout ([\#7891](matrix-org/matrix-react-sdk#7891)). Fixes element-hq/element-web#21180.
* Fix event list summary 1 hidden message pluralisation ([\#7890](matrix-org/matrix-react-sdk#7890)). Fixes element-hq/element-web#21196.
* Fix vanishing recently viewed menu ([\#7887](matrix-org/matrix-react-sdk#7887)). Fixes element-hq/element-web#20827.
* Fix freeze on room switch ([\#7884](matrix-org/matrix-react-sdk#7884)). Fixes element-hq/element-web#21127.
* Check 'useSystemTheme' in quick settings theme switcher ([\#7809](matrix-org/matrix-react-sdk#7809)). Fixes element-hq/element-web#21061.
* Fix 'my threads' filtering to include participated threads ([\#7882](matrix-org/matrix-react-sdk#7882)). Fixes element-hq/element-web#20877.
* Remove log line to try to fix freeze on answering VoIP call ([\#7883](matrix-org/matrix-react-sdk#7883)).
* Support social login & password on soft logout page ([\#7879](matrix-org/matrix-react-sdk#7879)). Fixes element-hq/element-web#21099.
* Fix missing padding on server picker ([\#7864](matrix-org/matrix-react-sdk#7864)).
* Throttle RoomState.members handlers ([\#7876](matrix-org/matrix-react-sdk#7876)). Fixes element-hq/element-web#21127.
* Only show joined/invited in search dialog ([\#7875](matrix-org/matrix-react-sdk#7875)). Fixes element-hq/element-web#21161.
* Don't pillify code blocks ([\#7861](matrix-org/matrix-react-sdk#7861)). Fixes element-hq/element-web#20851 and element-hq/element-web#18687.
* Fix keyboard shortcut icons on macOS ([\#7869](matrix-org/matrix-react-sdk#7869)).
su-ex added a commit to SchildiChat/element-web that referenced this issue Mar 17, 2022
@su-ex
Merge tag 'v1.10.7' into sc
6dabd39 
* Fix a bug where URL previews could be enabled in the left-panel when they
should not have been.
* Add a config.json option to skip the built-in Jitsi welcome screen ([\element-hq#21190](element-hq#21190)).
* Add unexposed account setting for hiding poll creation ([\#7972](matrix-org/matrix-react-sdk#7972)).
* Allow pinning polls ([\element-hq#7922](matrix-org/matrix-react-sdk#7922)). Fixes element-hq#20152.
* Make trailing `:` into a setting ([\element-hq#6711](matrix-org/matrix-react-sdk#6711)). Fixes element-hq#16682. Contributed by @SimonBrandner.
* Location sharing > back button ([\element-hq#7958](matrix-org/matrix-react-sdk#7958)).
* use LocationAssetType ([\element-hq#7965](matrix-org/matrix-react-sdk#7965)).
* Location share type UI ([\element-hq#7924](matrix-org/matrix-react-sdk#7924)).
* Add a few more UIComponent flags, and ensure they are used in existing code ([\element-hq#7937](matrix-org/matrix-react-sdk#7937)).
* Add support for overriding strings in the app ([\element-hq#7886](matrix-org/matrix-react-sdk#7886)).
* Add support for redirecting to external pages after logout ([\element-hq#7905](matrix-org/matrix-react-sdk#7905)).
* Expose redaction power level in room settings ([\element-hq#7599](matrix-org/matrix-react-sdk#7599)). Fixes element-hq#20590. Contributed by @SimonBrandner.
* Update and expand ways to access pinned messages ([\#7906](matrix-org/matrix-react-sdk#7906)). Fixes element-hq#21209 and element-hq#21211.
* Add slash command to switch to a room's virtual room ([\element-hq#7839](matrix-org/matrix-react-sdk#7839)).
* Remove Lojban translation ([\element-hq#21302](element-hq#21302)).
* Merge pull request from GHSA-qmf4-7w7j-vf23 ([\element-hq#8059](matrix-org/matrix-react-sdk#8059)).
* Add another null guard for member ([\element-hq#7984](matrix-org/matrix-react-sdk#7984)). Fixes element-hq#21319.
* Fix room account settings ([\element-hq#7999](matrix-org/matrix-react-sdk#7999)).
* Fix missing summary text for pinned message changes ([\element-hq#7989](matrix-org/matrix-react-sdk#7989)). Fixes element-hq#19823.
* Pass room to getRoomTombstone to avoid racing with setState ([\element-hq#7986](matrix-org/matrix-react-sdk#7986)).
* Hide composer and call buttons when the room is tombstoned ([\element-hq#7975](matrix-org/matrix-react-sdk#7975)). Fixes element-hq#21286.
* Fix bad ternary statement in autocomplete user pill insertions ([\element-hq#7977](matrix-org/matrix-react-sdk#7977)). Fixes element-hq#21307.
* Fix sending locations into threads and fix i18n ([\element-hq#7943](matrix-org/matrix-react-sdk#7943)). Fixes element-hq#21267.
* Fix location map attribution rendering over message action bar ([\element-hq#7974](matrix-org/matrix-react-sdk#7974)). Fixes element-hq#21297.
* Fix wrongly asserting that PushRule::conditions is non-null ([\element-hq#7973](matrix-org/matrix-react-sdk#7973)). Fixes element-hq#21305.
* Fix account & room settings race condition ([\element-hq#7953](matrix-org/matrix-react-sdk#7953)). Fixes element-hq#21163.
* Fix bug with some space selections not being applied ([\element-hq#7971](matrix-org/matrix-react-sdk#7971)). Fixes element-hq#21290.
* Revert "replace all require(.svg) with esm import" ([\element-hq#7969](matrix-org/matrix-react-sdk#7969)). Fixes element-hq#21293.
* Hide unpinnable pinned messages in more cases ([\element-hq#7921](matrix-org/matrix-react-sdk#7921)).
* Fix room list being laggy while scrolling 🐌 ([\element-hq#7939](matrix-org/matrix-react-sdk#7939)). Fixes element-hq#21262.
* Make pinned messages more reliably reflect edits ([\element-hq#7920](matrix-org/matrix-react-sdk#7920)). Fixes element-hq#17098.
* Improve accessibility of the BetaPill ([\element-hq#7949](matrix-org/matrix-react-sdk#7949)). Fixes element-hq#21255.
* Autofocus correct composer after sending reaction ([\element-hq#7950](matrix-org/matrix-react-sdk#7950)). Fixes element-hq#21273.
* Consider polls as message events for rendering redactions ([\element-hq#7944](matrix-org/matrix-react-sdk#7944)). Fixes element-hq#21125.
* Prevent event tiles being shrunk/collapsed by flexbox ([\element-hq#7942](matrix-org/matrix-react-sdk#7942)). Fixes element-hq#21269.
* Fix ExportDialog title on export cancellation ([\element-hq#7936](matrix-org/matrix-react-sdk#7936)). Fixes element-hq#21260. Contributed by @luixxiul.
* Mandate use of js-sdk/src/matrix import over js-sdk/src ([\element-hq#7933](matrix-org/matrix-react-sdk#7933)). Fixes element-hq#21253.
* Fix backspace not working in the invite dialog ([\element-hq#7931](matrix-org/matrix-react-sdk#7931)). Fixes element-hq#21249. Contributed by @SimonBrandner.
* Fix right panel soft crashes due to missing room prop ([\element-hq#7923](matrix-org/matrix-react-sdk#7923)). Fixes element-hq#21243.
* fix color of location share caret ([\element-hq#7917](matrix-org/matrix-react-sdk#7917)).
* Wrap all EventTiles with a TileErrorBoundary and guard parsePermalink ([\element-hq#7916](matrix-org/matrix-react-sdk#7916)). Fixes element-hq#21216.
* Fix changing space sometimes bouncing to the wrong space ([\element-hq#7910](matrix-org/matrix-react-sdk#7910)). Fixes element-hq#20425.
* Ensure EventListSummary key does not change during backpagination ([\element-hq#7915](matrix-org/matrix-react-sdk#7915)). Fixes element-hq#9192.
* Fix positioning of the thread context menu ([\element-hq#7918](matrix-org/matrix-react-sdk#7918)). Fixes element-hq#21236.
* Inject sender into pinned messages ([\element-hq#7904](matrix-org/matrix-react-sdk#7904)). Fixes element-hq#20314.
* Tweak info message padding in right panel timeline ([\#7901](matrix-org/matrix-react-sdk#7901)). Fixes element-hq#21212.
* Fix another freeze on room switch ([\#7900](matrix-org/matrix-react-sdk#7900)). Fixes element-hq#21127.
* Fix out of memory error when failing to acquire location ([\element-hq#7902](matrix-org/matrix-react-sdk#7902)). Fixes element-hq#21213.
* Fix edge case in context menu chevron positioning ([\element-hq#7899](matrix-org/matrix-react-sdk#7899)).
* Fix composer format buttons on WebKit ([\element-hq#7898](matrix-org/matrix-react-sdk#7898)). Fixes element-hq#20868.
* manage voicerecording state when deleting or sending a voice message ([\element-hq#7896](matrix-org/matrix-react-sdk#7896)). Fixes element-hq#21151.
* Fix bug with useRoomHierarchy tight-looping loadMore on error ([\element-hq#7893](matrix-org/matrix-react-sdk#7893)).
* Fix upload button & shortcut not working for narrow composer mode ([\element-hq#7894](matrix-org/matrix-react-sdk#7894)). Fixes element-hq#21175 and element-hq#21142.
* Fix emoji insertion in thread composer going to the main composer ([\element-hq#7895](matrix-org/matrix-react-sdk#7895)). Fixes element-hq#21202.
* Try harder to keep context menus inside the window ([\element-hq#7863](matrix-org/matrix-react-sdk#7863)). Fixes element-hq#17527 and element-hq#18377.
* Fix edge case around event list summary layout ([\element-hq#7891](matrix-org/matrix-react-sdk#7891)). Fixes element-hq#21180.
* Fix event list summary 1 hidden message pluralisation ([\element-hq#7890](matrix-org/matrix-react-sdk#7890)). Fixes element-hq#21196.
* Fix vanishing recently viewed menu ([\element-hq#7887](matrix-org/matrix-react-sdk#7887)). Fixes element-hq#20827.
* Fix freeze on room switch ([\element-hq#7884](matrix-org/matrix-react-sdk#7884)). Fixes element-hq#21127.
* Check 'useSystemTheme' in quick settings theme switcher ([\element-hq#7809](matrix-org/matrix-react-sdk#7809)). Fixes element-hq#21061.
* Fix 'my threads' filtering to include participated threads ([\element-hq#7882](matrix-org/matrix-react-sdk#7882)). Fixes element-hq#20877.
* Remove log line to try to fix freeze on answering VoIP call ([\element-hq#7883](matrix-org/matrix-react-sdk#7883)).
* Support social login & password on soft logout page ([\element-hq#7879](matrix-org/matrix-react-sdk#7879)). Fixes element-hq#21099.
* Fix missing padding on server picker ([\element-hq#7864](matrix-org/matrix-react-sdk#7864)).
* Throttle RoomState.members handlers ([\element-hq#7876](matrix-org/matrix-react-sdk#7876)). Fixes element-hq#21127.
* Only show joined/invited in search dialog ([\element-hq#7875](matrix-org/matrix-react-sdk#7875)). Fixes element-hq#21161.
* Don't pillify code blocks ([\element-hq#7861](matrix-org/matrix-react-sdk#7861)). Fixes element-hq#20851 and element-hq#18687.
* Fix keyboard shortcut icons on macOS ([\element-hq#7869](matrix-org/matrix-react-sdk#7869)).
su-ex added a commit to SchildiChat/matrix-react-sdk that referenced this issue Mar 17, 2022
@su-ex
Merge tag 'v3.42.0' into sc
3f94a5d 
* Fix a bug where URL previews could be enabled in the left-panel when they
should not have been.
* Add unexposed account setting for hiding poll creation ([\matrix-org#7972](matrix-org#7972)).
* Allow pinning polls ([\matrix-org#7922](matrix-org#7922)). Fixes element-hq/element-web#20152.
* Make trailing `:` into a setting ([\matrix-org#6711](matrix-org#6711)). Fixes element-hq/element-web#16682. Contributed by @SimonBrandner.
* Location sharing > back button ([\matrix-org#7958](matrix-org#7958)).
* use LocationAssetType ([\matrix-org#7965](matrix-org#7965)).
* Location share type UI ([\matrix-org#7924](matrix-org#7924)).
* Add a few more UIComponent flags, and ensure they are used in existing code ([\matrix-org#7937](matrix-org#7937)).
* Add support for overriding strings in the app ([\matrix-org#7886](matrix-org#7886)).
* Add support for redirecting to external pages after logout ([\matrix-org#7905](matrix-org#7905)).
* Expose redaction power level in room settings ([\matrix-org#7599](matrix-org#7599)). Fixes element-hq/element-web#20590. Contributed by @SimonBrandner.
* Update and expand ways to access pinned messages ([\matrix-org#7906](matrix-org#7906)). Fixes element-hq/element-web#21209 and element-hq/element-web#21211.
* Add slash command to switch to a room's virtual room ([\matrix-org#7839](matrix-org#7839)).
* Merge pull request from GHSA-qmf4-7w7j-vf23 ([\matrix-org#8059](matrix-org#8059)).
* Add another null guard for member ([\matrix-org#7984](matrix-org#7984)). Fixes element-hq/element-web#21319.
* Fix room account settings ([\matrix-org#7999](matrix-org#7999)).
* Fix missing summary text for pinned message changes ([\matrix-org#7989](matrix-org#7989)). Fixes element-hq/element-web#19823.
* Pass room to getRoomTombstone to avoid racing with setState ([\matrix-org#7986](matrix-org#7986)).
* Hide composer and call buttons when the room is tombstoned ([\matrix-org#7975](matrix-org#7975)). Fixes element-hq/element-web#21286.
* Fix bad ternary statement in autocomplete user pill insertions ([\matrix-org#7977](matrix-org#7977)). Fixes element-hq/element-web#21307.
* Fix sending locations into threads and fix i18n ([\matrix-org#7943](matrix-org#7943)). Fixes element-hq/element-web#21267.
* Fix location map attribution rendering over message action bar ([\matrix-org#7974](matrix-org#7974)). Fixes element-hq/element-web#21297.
* Fix wrongly asserting that PushRule::conditions is non-null ([\matrix-org#7973](matrix-org#7973)). Fixes element-hq/element-web#21305.
* Fix account & room settings race condition ([\matrix-org#7953](matrix-org#7953)). Fixes element-hq/element-web#21163.
* Fix bug with some space selections not being applied ([\matrix-org#7971](matrix-org#7971)). Fixes element-hq/element-web#21290.
* Revert "replace all require(.svg) with esm import" ([\matrix-org#7969](matrix-org#7969)). Fixes element-hq/element-web#21293.
* Hide unpinnable pinned messages in more cases ([\matrix-org#7921](matrix-org#7921)).
* Fix room list being laggy while scrolling 🐌 ([\matrix-org#7939](matrix-org#7939)). Fixes element-hq/element-web#21262.
* Make pinned messages more reliably reflect edits ([\matrix-org#7920](matrix-org#7920)). Fixes element-hq/element-web#17098.
* Improve accessibility of the BetaPill ([\matrix-org#7949](matrix-org#7949)). Fixes element-hq/element-web#21255.
* Autofocus correct composer after sending reaction ([\matrix-org#7950](matrix-org#7950)). Fixes element-hq/element-web#21273.
* Consider polls as message events for rendering redactions ([\matrix-org#7944](matrix-org#7944)). Fixes element-hq/element-web#21125.
* Prevent event tiles being shrunk/collapsed by flexbox ([\matrix-org#7942](matrix-org#7942)). Fixes element-hq/element-web#21269.
* Fix ExportDialog title on export cancellation ([\matrix-org#7936](matrix-org#7936)). Fixes element-hq/element-web#21260. Contributed by @luixxiul.
* Mandate use of js-sdk/src/matrix import over js-sdk/src ([\matrix-org#7933](matrix-org#7933)). Fixes element-hq/element-web#21253.
* Fix backspace not working in the invite dialog ([\matrix-org#7931](matrix-org#7931)). Fixes element-hq/element-web#21249. Contributed by @SimonBrandner.
* Fix right panel soft crashes due to missing room prop ([\matrix-org#7923](matrix-org#7923)). Fixes element-hq/element-web#21243.
* fix color of location share caret ([\matrix-org#7917](matrix-org#7917)).
* Wrap all EventTiles with a TileErrorBoundary and guard parsePermalink ([\matrix-org#7916](matrix-org#7916)). Fixes element-hq/element-web#21216.
* Fix changing space sometimes bouncing to the wrong space ([\matrix-org#7910](matrix-org#7910)). Fixes element-hq/element-web#20425.
* Ensure EventListSummary key does not change during backpagination ([\matrix-org#7915](matrix-org#7915)). Fixes element-hq/element-web#9192.
* Fix positioning of the thread context menu ([\matrix-org#7918](matrix-org#7918)). Fixes element-hq/element-web#21236.
* Inject sender into pinned messages ([\matrix-org#7904](matrix-org#7904)). Fixes element-hq/element-web#20314.
* Tweak info message padding in right panel timeline ([\matrix-org#7901](matrix-org#7901)). Fixes element-hq/element-web#21212.
* Fix another freeze on room switch ([\matrix-org#7900](matrix-org#7900)). Fixes element-hq/element-web#21127.
* Clean up error listener when location picker closes ([\matrix-org#7902](matrix-org#7902)). Fixes element-hq/element-web#21213.
* Fix edge case in context menu chevron positioning ([\matrix-org#7899](matrix-org#7899)).
* Fix composer format buttons on WebKit ([\matrix-org#7898](matrix-org#7898)). Fixes element-hq/element-web#20868.
* manage voicerecording state when deleting or sending a voice message ([\matrix-org#7896](matrix-org#7896)). Fixes element-hq/element-web#21151.
* Fix bug with useRoomHierarchy tight-looping loadMore on error ([\matrix-org#7893](matrix-org#7893)).
* Fix upload button & shortcut not working for narrow composer mode ([\matrix-org#7894](matrix-org#7894)). Fixes element-hq/element-web#21175 and element-hq/element-web#21142.
* Fix emoji insertion in thread composer going to the main composer ([\matrix-org#7895](matrix-org#7895)). Fixes element-hq/element-web#21202.
* Try harder to keep context menus inside the window ([\matrix-org#7863](matrix-org#7863)). Fixes element-hq/element-web#17527 and element-hq/element-web#18377.
* Fix edge case around event list summary layout ([\matrix-org#7891](matrix-org#7891)). Fixes element-hq/element-web#21180.
* Fix event list summary 1 hidden message pluralisation ([\matrix-org#7890](matrix-org#7890)). Fixes element-hq/element-web#21196.
* Fix vanishing recently viewed menu ([\matrix-org#7887](matrix-org#7887)). Fixes element-hq/element-web#20827.
* Fix freeze on room switch ([\matrix-org#7884](matrix-org#7884)). Fixes element-hq/element-web#21127.
* Check 'useSystemTheme' in quick settings theme switcher ([\matrix-org#7809](matrix-org#7809)). Fixes element-hq/element-web#21061.
* Fix 'my threads' filtering to include participated threads ([\matrix-org#7882](matrix-org#7882)). Fixes element-hq/element-web#20877.
* Remove log line to try to fix freeze on answering VoIP call ([\matrix-org#7883](matrix-org#7883)).
* Support social login & password on soft logout page ([\matrix-org#7879](matrix-org#7879)). Fixes element-hq/element-web#21099.
* Fix missing padding on server picker ([\matrix-org#7864](matrix-org#7864)).
* Throttle RoomState.members handlers ([\matrix-org#7876](matrix-org#7876)). Fixes element-hq/element-web#21127.
* Only show joined/invited in search dialog ([\matrix-org#7875](matrix-org#7875)). Fixes element-hq/element-web#21161.
* Don't pillify code blocks ([\matrix-org#7861](matrix-org#7861)). Fixes element-hq/element-web#20851 and element-hq/element-web#18687.
* Fix keyboard shortcut icons on macOS ([\matrix-org#7869](matrix-org#7869)).
su-ex added a commit to SchildiChat/element-desktop that referenced this issue Apr 1, 2022
@su-ex
Merge tag 'v1.10.8' into sc
14e9b02 
* Fix a bug where URL previews could be enabled in the left-panel when they
should not have been.
* Add a config.json option to skip the built-in Jitsi welcome screen ([\#21190](element-hq/element-web#21190)).
* Add unexposed account setting for hiding poll creation ([\#7972](matrix-org/matrix-react-sdk#7972)).
* Allow pinning polls ([\#7922](matrix-org/matrix-react-sdk#7922)). Fixes element-hq/element-web#20152.
* Make trailing `:` into a setting ([\#6711](matrix-org/matrix-react-sdk#6711)). Fixes element-hq/element-web#16682. Contributed by @SimonBrandner.
* Location sharing > back button ([\#7958](matrix-org/matrix-react-sdk#7958)).
* use LocationAssetType ([\#7965](matrix-org/matrix-react-sdk#7965)).
* Location share type UI ([\#7924](matrix-org/matrix-react-sdk#7924)).
* Add a few more UIComponent flags, and ensure they are used in existing code ([\#7937](matrix-org/matrix-react-sdk#7937)).
* Add support for overriding strings in the app ([\#7886](matrix-org/matrix-react-sdk#7886)).
* Add support for redirecting to external pages after logout ([\#7905](matrix-org/matrix-react-sdk#7905)).
* Expose redaction power level in room settings ([\#7599](matrix-org/matrix-react-sdk#7599)). Fixes element-hq/element-web#20590. Contributed by @SimonBrandner.
* Update and expand ways to access pinned messages ([\#7906](matrix-org/matrix-react-sdk#7906)). Fixes element-hq/element-web#21209 and element-hq/element-web#21211.
* Add slash command to switch to a room's virtual room ([\#7839](matrix-org/matrix-react-sdk#7839)).
* Remove Lojban translation ([\#21302](element-hq/element-web#21302)).
* Merge pull request from GHSA-qmf4-7w7j-vf23 ([\#8059](matrix-org/matrix-react-sdk#8059)).
* Add another null guard for member ([\#7984](matrix-org/matrix-react-sdk#7984)). Fixes element-hq/element-web#21319.
* Fix room account settings ([\#7999](matrix-org/matrix-react-sdk#7999)).
* Fix missing summary text for pinned message changes ([\#7989](matrix-org/matrix-react-sdk#7989)). Fixes element-hq/element-web#19823.
* Pass room to getRoomTombstone to avoid racing with setState ([\#7986](matrix-org/matrix-react-sdk#7986)).
* Hide composer and call buttons when the room is tombstoned ([\#7975](matrix-org/matrix-react-sdk#7975)). Fixes element-hq/element-web#21286.
* Fix bad ternary statement in autocomplete user pill insertions ([\#7977](matrix-org/matrix-react-sdk#7977)). Fixes element-hq/element-web#21307.
* Fix sending locations into threads and fix i18n ([\#7943](matrix-org/matrix-react-sdk#7943)). Fixes element-hq/element-web#21267.
* Fix location map attribution rendering over message action bar ([\#7974](matrix-org/matrix-react-sdk#7974)). Fixes element-hq/element-web#21297.
* Fix wrongly asserting that PushRule::conditions is non-null ([\#7973](matrix-org/matrix-react-sdk#7973)). Fixes element-hq/element-web#21305.
* Fix account & room settings race condition ([\#7953](matrix-org/matrix-react-sdk#7953)). Fixes element-hq/element-web#21163.
* Fix bug with some space selections not being applied ([\#7971](matrix-org/matrix-react-sdk#7971)). Fixes element-hq/element-web#21290.
* Revert "replace all require(.svg) with esm import" ([\#7969](matrix-org/matrix-react-sdk#7969)). Fixes element-hq/element-web#21293.
* Hide unpinnable pinned messages in more cases ([\#7921](matrix-org/matrix-react-sdk#7921)).
* Fix room list being laggy while scrolling 🐌 ([\#7939](matrix-org/matrix-react-sdk#7939)). Fixes element-hq/element-web#21262.
* Make pinned messages more reliably reflect edits ([\#7920](matrix-org/matrix-react-sdk#7920)). Fixes element-hq/element-web#17098.
* Improve accessibility of the BetaPill ([\#7949](matrix-org/matrix-react-sdk#7949)). Fixes element-hq/element-web#21255.
* Autofocus correct composer after sending reaction ([\#7950](matrix-org/matrix-react-sdk#7950)). Fixes element-hq/element-web#21273.
* Consider polls as message events for rendering redactions ([\#7944](matrix-org/matrix-react-sdk#7944)). Fixes element-hq/element-web#21125.
* Prevent event tiles being shrunk/collapsed by flexbox ([\#7942](matrix-org/matrix-react-sdk#7942)). Fixes element-hq/element-web#21269.
* Fix ExportDialog title on export cancellation ([\#7936](matrix-org/matrix-react-sdk#7936)). Fixes element-hq/element-web#21260. Contributed by @luixxiul.
* Mandate use of js-sdk/src/matrix import over js-sdk/src ([\#7933](matrix-org/matrix-react-sdk#7933)). Fixes element-hq/element-web#21253.
* Fix backspace not working in the invite dialog ([\#7931](matrix-org/matrix-react-sdk#7931)). Fixes element-hq/element-web#21249. Contributed by @SimonBrandner.
* Fix right panel soft crashes due to missing room prop ([\#7923](matrix-org/matrix-react-sdk#7923)). Fixes element-hq/element-web#21243.
* fix color of location share caret ([\#7917](matrix-org/matrix-react-sdk#7917)).
* Wrap all EventTiles with a TileErrorBoundary and guard parsePermalink ([\#7916](matrix-org/matrix-react-sdk#7916)). Fixes element-hq/element-web#21216.
* Fix changing space sometimes bouncing to the wrong space ([\#7910](matrix-org/matrix-react-sdk#7910)). Fixes element-hq/element-web#20425.
* Ensure EventListSummary key does not change during backpagination ([\#7915](matrix-org/matrix-react-sdk#7915)). Fixes element-hq/element-web#9192.
* Fix positioning of the thread context menu ([\#7918](matrix-org/matrix-react-sdk#7918)). Fixes element-hq/element-web#21236.
* Inject sender into pinned messages ([\#7904](matrix-org/matrix-react-sdk#7904)). Fixes element-hq/element-web#20314.
* Tweak info message padding in right panel timeline ([\#7901](matrix-org/matrix-react-sdk#7901)). Fixes element-hq/element-web#21212.
* Fix another freeze on room switch ([\#7900](matrix-org/matrix-react-sdk#7900)). Fixes element-hq/element-web#21127.
* Clean up error listener when location picker closes ([\#7902](matrix-org/matrix-react-sdk#7902)). Fixes element-hq/element-web#21213.
* Fix edge case in context menu chevron positioning ([\#7899](matrix-org/matrix-react-sdk#7899)).
* Fix composer format buttons on WebKit ([\#7898](matrix-org/matrix-react-sdk#7898)). Fixes element-hq/element-web#20868.
* manage voicerecording state when deleting or sending a voice message ([\#7896](matrix-org/matrix-react-sdk#7896)). Fixes element-hq/element-web#21151.
* Fix bug with useRoomHierarchy tight-looping loadMore on error ([\#7893](matrix-org/matrix-react-sdk#7893)).
* Fix upload button & shortcut not working for narrow composer mode ([\#7894](matrix-org/matrix-react-sdk#7894)). Fixes element-hq/element-web#21175 and element-hq/element-web#21142.
* Fix emoji insertion in thread composer going to the main composer ([\#7895](matrix-org/matrix-react-sdk#7895)). Fixes element-hq/element-web#21202.
* Try harder to keep context menus inside the window ([\#7863](matrix-org/matrix-react-sdk#7863)). Fixes element-hq/element-web#17527 and element-hq/element-web#18377.
* Fix edge case around event list summary layout ([\#7891](matrix-org/matrix-react-sdk#7891)). Fixes element-hq/element-web#21180.
* Fix event list summary 1 hidden message pluralisation ([\#7890](matrix-org/matrix-react-sdk#7890)). Fixes element-hq/element-web#21196.
* Fix vanishing recently viewed menu ([\#7887](matrix-org/matrix-react-sdk#7887)). Fixes element-hq/element-web#20827.
* Fix freeze on room switch ([\#7884](matrix-org/matrix-react-sdk#7884)). Fixes element-hq/element-web#21127.
* Check 'useSystemTheme' in quick settings theme switcher ([\#7809](matrix-org/matrix-react-sdk#7809)). Fixes element-hq/element-web#21061.
* Fix 'my threads' filtering to include participated threads ([\#7882](matrix-org/matrix-react-sdk#7882)). Fixes element-hq/element-web#20877.
* Remove log line to try to fix freeze on answering VoIP call ([\#7883](matrix-org/matrix-react-sdk#7883)).
* Support social login & password on soft logout page ([\#7879](matrix-org/matrix-react-sdk#7879)). Fixes element-hq/element-web#21099.
* Fix missing padding on server picker ([\#7864](matrix-org/matrix-react-sdk#7864)).
* Throttle RoomState.members handlers ([\#7876](matrix-org/matrix-react-sdk#7876)). Fixes element-hq/element-web#21127.
* Only show joined/invited in search dialog ([\#7875](matrix-org/matrix-react-sdk#7875)). Fixes element-hq/element-web#21161.
* Don't pillify code blocks ([\#7861](matrix-org/matrix-react-sdk#7861)). Fixes element-hq/element-web#20851 and element-hq/element-web#18687.
* Fix keyboard shortcut icons on macOS ([\#7869](matrix-org/matrix-react-sdk#7869)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robintown robintown

Labels
A-Message-Editing A-Message-Pinning T-Defect Z-Labs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make pinned messages more reliably reflect edits robintown/matrix-react-sdk
6 participants
@kittykat @t3chguy @HarHarLinks @aaronraimist @SimonBrandner @robintown