Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Some of your messages have not been sent" doesn't highlight the message when the unsent event doesn't have its own tile #18403

Closed
novocaine opened this issue Aug 5, 2021 · 8 comments
Labels
O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@novocaine
Copy link
Contributor

novocaine commented Aug 5, 2021

Description

Screenshot 2021-08-05 at 08 58 36

If an edit, reaction, or other event without its own tile is unsent, Element flags the problem but doesn't show which message has a related event pending.

Steps to reproduce

  • An edit (in my case) fails to send
  • Reload Element and view the channel

Acceptance criteria: highlight the pending related message somehow.

@novocaine novocaine added T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience X-Needs-Design labels Aug 5, 2021
@t3chguy
Copy link
Member

t3chguy commented Aug 5, 2021

Don't they get a red exclamation mark in the read receipt region and get kept at the bottom end of the timeline?

image

@novocaine
Copy link
Contributor Author

If so, there was no visible messaged marked in this way, so possible bug - I will try to repro.

@novocaine novocaine added X-Needs-Info This issue is blocked awaiting information from the reporter and removed X-Needs-Design labels Aug 5, 2021
@t3chguy
Copy link
Member

t3chguy commented Aug 5, 2021

Seems like related to #17078 in that case

@novocaine
Copy link
Contributor Author

I think the issue is that I have an unsent edit, which maybe we don't currently have a way of visualising.

unsentMessages contains an event like

"type": "m.room.encrypted",
    "content": {        
        "m.relates_to": {
            "rel_type": "m.replace",
            "event_id": "..."
        }
    },

I can't see reference to m.replace in the spec so can't confirm for sure.

@novocaine novocaine changed the title "Some of your messages have not been sent" should show me which messages are affected "Some of your messages have not been sent" doesn't highlight the message when the unsent message is an edit Aug 5, 2021
@novocaine
Copy link
Contributor Author

novocaine commented Aug 5, 2021

Ah, also, retry all doesn't actually clear it - the popup clears, but when I restart Element it comes back. Which sounds a bit like #17078

Deleting the messages .. works

@t3chguy
Copy link
Member

t3chguy commented Aug 5, 2021

Ah yes, unsent edits are only visible in the timeline if you have Show hidden events enabled

I can't see reference to m.replace in the spec so can't confirm for sure.

matrix-org/matrix-spec-proposals#2676

The edit itself is not meant to be visible in the timeline, but only affect the target event

@t3chguy
Copy link
Member

t3chguy commented Aug 5, 2021

ah, also, retry all doesn't actually clear it - the popup clears, but when I restart Element it comes back.

This sounds like a duplicate of #17589 then

@novocaine novocaine added O-Uncommon Most users are unlikely to come across this or unexpected workflow and removed X-Needs-Info This issue is blocked awaiting information from the reporter O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Aug 25, 2021
@novocaine novocaine changed the title "Some of your messages have not been sent" doesn't highlight the message when the unsent message is an edit "Some of your messages have not been sent" doesn't highlight the message when the unsent message doesn't have its own tile Nov 12, 2021
@novocaine novocaine changed the title "Some of your messages have not been sent" doesn't highlight the message when the unsent message doesn't have its own tile "Some of your messages have not been sent" doesn't highlight the message when the unsent event doesn't have its own tile Nov 12, 2021
@turt2live
Copy link
Member

turt2live commented May 7, 2022

Duplicate of #9692

@turt2live turt2live marked this as a duplicate of #9692 May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

No branches or pull requests

3 participants