Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Voice messages: "stop recording" layout shift #18416

Closed
turt2live opened this issue Aug 5, 2021 · 1 comment · Fixed by matrix-org/matrix-react-sdk#6572
Closed

Voice messages: "stop recording" layout shift #18416

turt2live opened this issue Aug 5, 2021 · 1 comment · Fixed by matrix-org/matrix-react-sdk#6572
Labels
A-Voice-Messages O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience P1 S-Minor Impairs non-critical functionality or suitable workarounds exist Sponsored X-Release-Blocker

Comments

@turt2live
Copy link
Member

From Nad at matrix-org/matrix-react-sdk#6530 (comment) :

It's a shame that when stopping recording the entire layout re-shuffles and your eye has to re-read the layout to know what happens:

Screenshot 2021-08-03 at 09 50 18

Screenshot 2021-08-03 at 09 50 13

Is there a simple way to re-arrange the interactions to avoid this?
@turt2live turt2live assigned turt2live and unassigned turt2live Aug 5, 2021
@germain-gg germain-gg added O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist labels Aug 6, 2021
@gaelledel
Copy link

@turt2live To solve the issue we could try to place the STOP button on the left of the player instead
so it'd be from the left to the right: Delete, Stop, Player, Send button. Let's review together when you're ready

turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 6, 2021
@turt2live
Move stop button to the left of the waveform
cab4f2e 
Fixes element-hq/element-web#18416
@turt2live turt2live mentioned this issue Aug 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Voice-Messages O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience P1 S-Minor Impairs non-critical functionality or suitable workarounds exist Sponsored X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move stop button to the left of the waveform matrix-org/matrix-react-sdk
3 participants
@germain-gg @turt2live @gaelledel