Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only add video elements to the DOM if you're in a call #20

Closed
ara4n opened this issue Aug 29, 2015 · 5 comments
Closed

Only add video elements to the DOM if you're in a call #20

ara4n opened this issue Aug 29, 2015 · 5 comments
Labels
P2 T-Task Tasks for the team like planning

Comments

@ara4n
Copy link
Member

ara4n commented Aug 29, 2015

No description provided.

@ara4n ara4n added the T-Task Tasks for the team like planning label Aug 29, 2015
@ara4n ara4n added P2 T-Task Tasks for the team like planning and removed T-Task Tasks for the team like planning labels Sep 7, 2015
@ara4n ara4n modified the milestone: Ragnarok Nov 29, 2015
@ara4n ara4n added P3 and removed P2 labels Dec 13, 2015
@ara4n ara4n added P2 and removed P3 labels Feb 19, 2016
@richvdh
Copy link
Member

richvdh commented Mar 10, 2016

Why?

@ara4n ara4n removed this from the Ragnarok milestone Apr 13, 2016
@ara4n
Copy link
Member Author

ara4n commented Jun 2, 2016

Because they take up resources, and you end up with weird shit like #1571

@ara4n ara4n mentioned this issue Jun 2, 2016
Closed
@richvdh
Copy link
Member

richvdh commented Oct 20, 2016

I don't think we have video elements when you're not in a call, but I can't see that we ever had? confused.com

dtygel pushed a commit to coletivoEITA/riot-web that referenced this issue May 5, 2017
@MTRNord
Merge pull request element-hq#20 from RiotTranslate/weblate-riot-web-…
5e09a48 
…riot-web

Update from Weblate.
@ara4n
Copy link
Member Author

ara4n commented May 15, 2017 •
edited
Loading

Looking in my DOM right now, whilst not on a VC (and not having been on one, afaik):

<div class="mx_VideoView"><div class="mx_VideoView_remoteVideoFeed"><video style="display: none; max-height: 227px;"></video></div><div class="mx_VideoView_localVideoFeed"><video style="display: none;"></video></div></div></div></div>

@SimonBrandner
Copy link
Contributor

We do this now

@linuxtim linuxtim mentioned this issue May 11, 2024
Closed
t3chguy pushed a commit that referenced this issue Oct 17, 2024
@Half-Shot @RiotRobot
Add timezone to user profile (#20)
eae9d9e 
* [create-pull-request] automated change (#12966)

Co-authored-by: github-merge-queue <[email protected]>

* Add timezone to right panel profile.

* Add setting to publish timezone

* Add string for timezone publish

* Automatically update timezone when setting changes.

* Refactor to using a hook

And automatically refresh the timezone every minute.

* Check for feature support for extended profiles.

* lint

* Add timezone

* Remove unintentional changes

* Use browser default timezone.

* lint

* tweaks

* Set timezone publish at the device level to prevent all devices writing to the timezone field.

* Update hook to use external client.

* Add test for user timezone.

* Update snapshot for preferences tab.

* Hide timezone info if not provided.

* Stablize test

* Fix date test types.

* prettier

* Add timezone tests

* Add test for invalid timezone.

* Update screenshot

* Remove check for profile.

---------

Co-authored-by: ElementRobot <[email protected]>
Co-authored-by: github-merge-queue <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ara4n @richvdh @SimonBrandner